Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets separate the candle with respect to color #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lets separate the candle with respect to color #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions mpl_finance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def candlestick2_ochl(ax, opens, closes, highs, lows, width=4,


def candlestick2_ohlc(ax, opens, highs, lows, closes, width=4,
colorup='k', colordown='r',
colorup='k', colordown='r',colordoji='k',
alpha=0.75):
"""Represent the open, close as a bar line and high low range as a
vertical line.
Expand Down Expand Up @@ -605,11 +605,20 @@ def candlestick2_ohlc(ax, opens, highs, lows, closes, width=4,

colorup = mcolors.to_rgba(colorup, alpha)
colordown = mcolors.to_rgba(colordown, alpha)
colord = {True: colorup, False: colordown}
colors = [colord[open < close]
for open, close in zip(opens, closes)
if open != -1 and close != -1]

colordoji = mcolors.to_rgba(colordoji, alpha)
# colord = {True: colorup, False: colordown}
# colors = [colord[open < close]
# for open, close in zip(opens, closes)
# if open != -1 and close != -1]
colors = []
for open, close in zip(opens, closes):
if open != -1 and close != -1:
if open < close:
colors.append(colorup)
elif open > close:
colors.append(colordown)
else:
Copy link
Contributor

@DanielGoldfarb DanielGoldfarb Nov 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubaidsworld Do you want to use some kind of a tolerance here? As written, it seems to me, that you will get your doji color only if the open and close are exactly equal (which in real life would be a very rare event indeed). Is that what you want? Did you run this code against any real data and are you happy with the way it works?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respected Sir,
Here are the answer to what you have asked me in the above conversation.
Do you want to use some kind of a tolerance here?
No. I do not want any tolerance as the doji candle I expected is to be gray in color. The growing or up candles in Green and the degrading or down candles in Red color. These look somewhat standard.
I, often, get doji candles. And that will help me in separating them from the up and down candles.
Is that what you want? Did you run this code against any real data and are you happy with the way it works?
Yes, I want that. I have tried it too. On my system I have made the changes with the library. And have got excellent experience viewing the candles through Matplotlib library mpl-finance.
Please have a look at this image:
Fig_164
I hope that your doubts are cleared.

colors.append(colordoji)
useAA = 0, # use tuple here
lw = 0.5, # and here
rangeCollection = LineCollection(rangeSegments,
Expand Down