Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets separate the candle with respect to color #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ubaidsworld
Copy link

added a code so that person can separate the display of the candles in understanding format.

added a code so that person can separate the display of the candles in understanding format.
colors.append(colorup)
elif open > close:
colors.append(colordown)
else:
Copy link
Contributor

@DanielGoldfarb DanielGoldfarb Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubaidsworld Do you want to use some kind of a tolerance here? As written, it seems to me, that you will get your doji color only if the open and close are exactly equal (which in real life would be a very rare event indeed). Is that what you want? Did you run this code against any real data and are you happy with the way it works?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respected Sir,
Here are the answer to what you have asked me in the above conversation.
Do you want to use some kind of a tolerance here?
No. I do not want any tolerance as the doji candle I expected is to be gray in color. The growing or up candles in Green and the degrading or down candles in Red color. These look somewhat standard.
I, often, get doji candles. And that will help me in separating them from the up and down candles.
Is that what you want? Did you run this code against any real data and are you happy with the way it works?
Yes, I want that. I have tried it too. On my system I have made the changes with the library. And have got excellent experience viewing the candles through Matplotlib library mpl-finance.
Please have a look at this image:
Fig_164
I hope that your doubts are cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants