Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinkedMapProvider.php #38380

Closed
wants to merge 4 commits into from
Closed

Update LinkedMapProvider.php #38380

wants to merge 4 commits into from

Conversation

sheepfy
Copy link
Contributor

@sheepfy sheepfy commented Jan 25, 2024

Related to #32221
Fix issue #9799

Resolved issues:

  1. resolves [Issue] Update LinkedMapProvider.php #38434: Update LinkedMapProvider.php

Copy link

m2-assistant bot commented Jan 25, 2024

Hi @sheepfy. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@andrewbess andrewbess added Component: Catalog Release Line: 2.4 Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P3 May be fixed according to the position in the backlog. labels Jan 25, 2024
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sheepfy
Thank you for your contribution
Looks good for me
Approved

@andrewbess
Copy link
Contributor

@magento run all tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta
Copy link
Contributor

@magento create issue

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Feb 9, 2024

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to app/code/Magento/Catalog/Model/ProductLink/CollectionProvider/LinkedMapProvider.php
  2. Verify Update LinkedMapProvider.php
  3. Check for $collection->setPositionOrder(); is added

Before: ✖️ 

Screenshot 2024-02-09 at 4 49 33 PM

After: ✔️  

Screenshot 2024-02-09 at 4 58 37 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

1 similar comment
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Bravo
Copy link
Contributor

Hi @sheepfy,

Thanks for your contribution!

We have followed these steps described here #9799 and we are not able to reproduce the issue in Latest 2.4-develop instance.

Please refer this #9799 (comment) if you are able to reproduce the issue and if we are missing anything please feel free to let us/reopen the PR.

Hence we are closing this PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Update LinkedMapProvider.php
5 participants