Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-9799: Show related products ordered by position #32221

Closed
wants to merge 1 commit into from
Closed

ISSUE-9799: Show related products ordered by position #32221

wants to merge 1 commit into from

Conversation

sheepfy
Copy link
Contributor

@sheepfy sheepfy commented Feb 18, 2021

Fix issue #9799

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @sheepfy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Stepa4man
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sheepfy
Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-8830 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Stepa4man Stepa4man added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 27, 2021
@andrewbess
Copy link
Contributor

This PR is merged.
Please reopen if it needed

@sheepfy
Copy link
Contributor Author

sheepfy commented Jan 25, 2024

@sheepfy
Copy link
Contributor Author

sheepfy commented Jan 25, 2024

cc @Stepa4man

@Stepa4man
Copy link
Contributor

Stepa4man commented Jan 25, 2024

@sheepfy Have no clue what's going on here;)
@andrewbess, bro, can you shed some light with us, please:)

@Stepa4man Stepa4man assigned andrewbess and unassigned Stepa4man Jan 25, 2024
@andrewbess
Copy link
Contributor

andrewbess commented Jan 25, 2024

Hello @sheepfy @Stepa4man

Thank you guys for your attentiveness.
Github showed me that this PR was already merged.
Also, I cannot reopen it due to Github shows me the next message "The repository that submitted this pull request has been deleted."
magento2 2024-01-25 12-49-20

Perhaps this is the problem.

Also, I think the main reason why this PR will not be take further is: "issue is closed". Maybe we need to reproduce the problem and reopen it.

@sheepfy Could you please resolve the problems and open new PR?

Thank you in advance.

@sheepfy sheepfy mentioned this pull request Jan 25, 2024
1 task
@sheepfy
Copy link
Contributor Author

sheepfy commented Jan 25, 2024

@andrewbess
added new PR
#38380

Steps to replicate the issue are described in #9799
For short, the order is not kept for linked products, even if the order was changed from admin via drag and drop (don't exactly remember where, in admin or in frontend), when I'll have the time, I'll put my explanation for how to replicate this later when I'll got some spare time, but main explanation was described in the issue.

The change from this PR was the fix I've done for my client.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants