-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-9799: Show related products ordered by position #32221
Conversation
Hi @sheepfy. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sheepfy
Thanks for your contribution
Hi @Stepa4man, thank you for the review.
|
This PR is merged. |
@andrewbess |
cc @Stepa4man |
@sheepfy Have no clue what's going on here;) |
Hello @sheepfy @Stepa4man Thank you guys for your attentiveness. Perhaps this is the problem. Also, I think the main reason why this PR will not be take further is: "issue is closed". Maybe we need to reproduce the problem and reopen it. @sheepfy Could you please resolve the problems and open new PR? Thank you in advance. |
@andrewbess Steps to replicate the issue are described in #9799 The change from this PR was the fix I've done for my client. |
Fix issue #9799