DM-48733: times-square - New template render route #4172
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ress There is a [new template rendering endpoint](lsst-sqre/times-square#92) in times square that finds a notebook template to render based on the GitHub URL path. We want to [use this new endpoint](lsst-sqre/rsp-jupyter-extensions#42) in our Jupyter extension to generate a notebook from a portal query so that we can further restrict this usage to only templates from certain GitHub repos, in this case, the lsst-sqre/nublado-seeds repo.
fajpunk
force-pushed
the
tickets/DM-48733/times-square-noteburst-idfprod
branch
from
74db7fc to
b9f99ac
Compare
8 tasks
fajpunk
force-pushed
the
tickets/DM-48733/times-square-noteburst-idfprod
branch
3 times, most recently
from
7187586 to
b9f99ac
Compare
…ting ingress" This reverts commit 801a55c.
|
So before we merge this we're going to drop commit 4f1030e, is that right? I hadn't realized that this change is effectively going to break the templating feature in older scilat-lab images because we can't backport rsp-jupyter-extensions to them (right?). This is worth bringing up at a standup, but on the other hand, I can't see a way around this. |
|
Yep, the ingress changes are going to break any lab without the rsp extensions changes for non-admins, and I too can't see a way to do it without breaking old sciplat-lab images. This was just intended to test that the planned ingress changes would work, I'm not intending it to be merged yet. I'm going to make another PR to just bump Times Square. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new endpoint was added to expose template rendering for a GitHub notebook template at a different path that includes the GitHub URL path for the notebook. This updates the template rendering
GafaelfawrIngressto restrict rendering to onlylsst-sqre/nublado-seedsrepo notebooks.Once this is merged, notebook-from-portal-query functionality won't work with any lab image that doesn't also have an
rsp-jupyter-extensionspackage with this change.