Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.17.0 #93

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Release 0.17.0 #93

merged 1 commit into from
Feb 6, 2025

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Feb 5, 2025

This contains an alternate GitHub-path-based template rendering endpoint so we can further restrict the parts of Times Square that we expose to non-admins. Including this, there are three changes to enable us to implement these restrictions:

Here are all of the combinations, a checked box means it works:

  • g_admin: times-square + rsp-jupyter-extensions + ingress
  • g_admin: times-square + rsp-jupyter-extensions
  • g_admin: times-square + ingress
  • g_admin: times-square
  • g_user: times-square + rsp-jupyter-extensions + ingress
  • g_user: times-square + rsp-jupyter-extensions
  • g_user: times-square + ingress
  • g_user: times-square

This Times Square change works with every other change for both admin and non-admin users except for non-admin users using a lab without an updated rsp-jupyter-extensions. So:

  • Times Square is safe to release with this change at any time
  • rsp-jupyter-extensions is safe to release after this Times Square change is deployed everywhere
  • The ingress changes will have to involve some more coordination

Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@fajpunk fajpunk merged commit a958bd6 into main Feb 6, 2025
4 checks passed
@fajpunk fajpunk deleted the tickets/DM-48733/release branch February 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants