Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains an alternate GitHub-path-based template rendering endpoint so we can further restrict the parts of Times Square that we expose to non-admins. Including this, there are three changes to enable us to implement these restrictions:
times-square
)rsp-jupyter-extensions
)Here are all of the combinations, a checked box means it works:
times-square
+rsp-jupyter-extensions
+ingress
times-square
+rsp-jupyter-extensions
times-square
+ingress
times-square
times-square
+rsp-jupyter-extensions
+ingress
times-square
+rsp-jupyter-extensions
times-square
+ingress
times-square
This Times Square change works with every other change for both admin and non-admin users except for non-admin users using a lab without an updated
rsp-jupyter-extensions
. So:rsp-jupyter-extensions
is safe to release after this Times Square change is deployed everywhere