RobustLineIntersector defensive copyWithZ check to avoid exception with CoordinateXY or CoordinateXYM #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodygarnett
force-pushed
the
copyWithZ_check
branch
2 times, most recently
from
dc8f9f5
to
234dbf0
Compare
Defensive check prevents copyWithZ, copyWithZInterpolate methods from throwing an exception when the target coordinate is CoordinateXY or CoordinateXYM. This is in addition to the existing defensive check to avoid doing anything if the z vale was Double.NaN.
jodygarnett
force-pushed
the
copyWithZ_check
branch
from
234dbf0
to
6177200
Compare
|
This is minimal change to avoid exception. I looked at "casting" coordinates to solve #375 but am uncomfortable doing so in performance sensitive code. |
|
Looks good to me. |
jodygarnett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defensive check prevents copyWithZ, copyWithZInterpolate methods from throwing an exception when the target coordinate is CoordinateXY or CoordinateXYM.
This is in addition to the existing defensive check to avoid doing anything if the z vale was Double.NaN.
This mitigates but does not solve #375 which is due to the intermixing of Coordinate and CoordinateXY values in GeoTools clipping code.