-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 1.2.0.0 release mid September #1070
Conversation
@jodygarnett Could you help @dr-jts with this PR? #734 We are pushing the Apache Parquet and Apache Iceberg community to use JTS WKB reader / writer (ISO variant) for encoding geometries with XYZM coordinates. I really want to fix this issue in this release otherwise this will lead to unexpected outcome in many cloud db engines. |
I am a little out of the loop; I see your questions on the PR - I think we should assume lack of resources for the project. I am trying to think of developers who would be comfortable reviewing such work... maybe Andrea or Gabe from the GeoTools project? aside: can you rebase and resolve conflicts please. |
Getting some test failures downstream in GeoTools:
The failures all look legitimate so far. Resolved with: #1071 |
Next change (unclear if regression or just different) comes from MaximumInscribedCircle.getCenter(multiPolygon, precision).
Internally this seems to be a difference with this call:
Returning:
Okay they uses different starting locations to start their grid:
|
Next change/regression appears to be a fragile test checking CentreLine and Skeletons coming out of VoronoiDiagramBuilder processing. Cannot really tell if this is an intensional change or a side effect as test lacks sufficient detail.
Here is the PR if you wish to see the different out: geotools/geotools#4884 |
202f964
to
09a221d
Compare
These release notes match up with: https://github.com/locationtech/jts/milestone/8?closed=1
This is the release review page: https://projects.eclipse.org/projects/locationtech.jts/releases/1.20.0
For background reading on RelateNG: