Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESI] BSP: variable sized reads and gearboxing read responses #8095

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

teqdruid
Copy link
Contributor

Adds the ability to have hostmem read clients issue reads for types which are not 64-bit. Requires changes to the cosimulated hostmem to properly respond with multiple messages when necessary. Also requires a tag-sensitive gearbox to re-assemble data which requires more than one message from upstream.

Adds the ability to have hostmem read clients issue reads for types
which are not 64-bit. Requires changes to the cosimulated hostmem to
properly respond with multiple messages when necessary. Also requires a
tag-sensitive gearbox to re-assemble data which requires more than one
message from upstream.
@teqdruid teqdruid added the ESI label Jan 17, 2025
@teqdruid teqdruid requested a review from Copilot January 17, 2025 22:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • lib/Dialect/ESI/runtime/cpp/lib/backends/Cosim.cpp: Language not supported
  • lib/Dialect/ESI/runtime/cpp/tools/esitester.cpp: Language not supported
  • frontends/PyCDE/integration_test/esitester.py: Evaluated as low risk
  • frontends/PyCDE/src/pycde/bsp/common.py: Evaluated as low risk
Comments suppressed due to low confidence (2)

frontends/PyCDE/test/test_esi.py:4

  • The import statement for 'unittest' is missing. This could cause issues with running the tests if they rely on 'unittest'. Add 'import unittest' at the beginning of the file.
from pycde import (Clock, Input, InputChannel, Output, OutputChannel, Module, Reset, generator, types)

frontends/PyCDE/src/pycde/constructs.py:266

  • Ensure that the new 'clear' input functionality in the Counter module is covered by tests.
clear = Input(Bits(1))
@teqdruid teqdruid changed the title [ESI] XRT BSP: variable sized reads and gearboxing read responses [ESI] BSP: variable sized reads and gearboxing read responses Jan 17, 2025
@teqdruid teqdruid merged commit 0637646 into main Jan 21, 2025
5 checks passed
@teqdruid teqdruid deleted the teqdruid/hostmem-readbytes branch January 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant