-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #3400
Spelling #3400
Conversation
Welcome @jsoref! |
Hi @jsoref. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hack/invalid-examples/standard/httproute/invalid-httpredirect-hostname.yaml
Outdated
Show resolved
Hide resolved
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough once over of the repositories spelling errors!
I read it all over, and everything here looks good to me except for historical GEP images which were accurate at the time (see comments below).
It occurred to me that would be nice if we could add checks that can run in CI to avoid these getting merged in the first place (however, that doesn't need to be the burden of this PR).
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
I'm happy to provide a version of this for CI after a version of this merges. It's used by a number majors projects. I'm happy to talk about that on slack/in an issue after this merges. |
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cc @mlavacca @robscott @youngnick for LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsoref, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @jsoref! /lgtm |
* spelling: adding Signed-off-by: Josh Soref <[email protected]> * spelling: anymore Signed-off-by: Josh Soref <[email protected]> * spelling: approach Signed-off-by: Josh Soref <[email protected]> * spelling: attached Signed-off-by: Josh Soref <[email protected]> * spelling: because Signed-off-by: Josh Soref <[email protected]> * spelling: cannot Signed-off-by: Josh Soref <[email protected]> * spelling: case-insensitive Signed-off-by: Josh Soref <[email protected]> * spelling: case-sensitive Signed-off-by: Josh Soref <[email protected]> * spelling: certificate Signed-off-by: Josh Soref <[email protected]> * spelling: certificates Signed-off-by: Josh Soref <[email protected]> * spelling: criteria Signed-off-by: Josh Soref <[email protected]> * spelling: deterministically Signed-off-by: Josh Soref <[email protected]> * spelling: discoverability Signed-off-by: Josh Soref <[email protected]> * spelling: docs Signed-off-by: Josh Soref <[email protected]> * spelling: encapsulated Signed-off-by: Josh Soref <[email protected]> * spelling: feature Signed-off-by: Josh Soref <[email protected]> * spelling: filesystem Signed-off-by: Josh Soref <[email protected]> * spelling: format Signed-off-by: Josh Soref <[email protected]> * spelling: frankbu Signed-off-by: Josh Soref <[email protected]> * spelling: github Signed-off-by: Josh Soref <[email protected]> * spelling: grpc Signed-off-by: Josh Soref <[email protected]> * spelling: grpcroute Signed-off-by: Josh Soref <[email protected]> * spelling: has Signed-off-by: Josh Soref <[email protected]> * spelling: have Signed-off-by: Josh Soref <[email protected]> * spelling: http-route Signed-off-by: Josh Soref <[email protected]> * spelling: httpproxy Signed-off-by: Josh Soref <[email protected]> * spelling: httpredirect Signed-off-by: Josh Soref <[email protected]> * spelling: https Signed-off-by: Josh Soref <[email protected]> * spelling: implementation Signed-off-by: Josh Soref <[email protected]> * spelling: improvements Signed-off-by: Josh Soref <[email protected]> * spelling: in Signed-off-by: Josh Soref <[email protected]> * spelling: infrastructure Signed-off-by: Josh Soref <[email protected]> * spelling: into Signed-off-by: Josh Soref <[email protected]> * spelling: intuitive Signed-off-by: Josh Soref <[email protected]> * spelling: its Signed-off-by: Josh Soref <[email protected]> * spelling: linked Signed-off-by: Josh Soref <[email protected]> * spelling: maintainers Signed-off-by: Josh Soref <[email protected]> * spelling: maintenance Signed-off-by: Josh Soref <[email protected]> * spelling: maximum Signed-off-by: Josh Soref <[email protected]> * spelling: negotiated Signed-off-by: Josh Soref <[email protected]> * spelling: networking Signed-off-by: Josh Soref <[email protected]> * spelling: nonexistent Signed-off-by: Josh Soref <[email protected]> * spelling: or Signed-off-by: Josh Soref <[email protected]> * spelling: overridden Signed-off-by: Josh Soref <[email protected]> * spelling: possible Signed-off-by: Josh Soref <[email protected]> * spelling: preexisting Signed-off-by: Josh Soref <[email protected]> * spelling: prominence Signed-off-by: Josh Soref <[email protected]> * spelling: protocol Signed-off-by: Josh Soref <[email protected]> * spelling: recommend Signed-off-by: Josh Soref <[email protected]> * spelling: referent Signed-off-by: Josh Soref <[email protected]> * spelling: release Signed-off-by: Josh Soref <[email protected]> * spelling: route-override Signed-off-by: Josh Soref <[email protected]> * spelling: stabilizing Signed-off-by: Josh Soref <[email protected]> * spelling: substituted Signed-off-by: Josh Soref <[email protected]> * spelling: targeting Signed-off-by: Josh Soref <[email protected]> * spelling: the Signed-off-by: Josh Soref <[email protected]> * spelling: validationutil Signed-off-by: Josh Soref <[email protected]> * spelling: which Signed-off-by: Josh Soref <[email protected]> * Reword simplify prototyping description Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/gateway-api/actions/runs/11444311412#summary-31838911907
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gateway-api/actions/runs/11444311702#summary-31838912845
It also fixes the labels of a pair of images to match the word actually used
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: