Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #3400

Merged
merged 59 commits into from
Feb 12, 2025
Merged

Spelling #3400

merged 59 commits into from
Feb 12, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 21, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/gateway-api/actions/runs/11444311412#summary-31838911907

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gateway-api/actions/runs/11444311702#summary-31838912845

It also fixes the labels of a pair of images to match the word actually used

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jsoref!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@jsoref
Copy link
Contributor Author

jsoref commented Jan 19, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough once over of the repositories spelling errors!

I read it all over, and everything here looks good to me except for historical GEP images which were accurate at the time (see comments below).

It occurred to me that would be nice if we could add checks that can run in CI to avoid these getting merged in the first place (however, that doesn't need to be the burden of this PR).

@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 11, 2025
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2025
@jsoref
Copy link
Contributor Author

jsoref commented Feb 11, 2025

I'm happy to provide a version of this for CI after a version of this merges. It's used by a number majors projects. I'm happy to talk about that on slack/in an issue after this merges.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/cc @mlavacca @robscott @youngnick for LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsoref, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 12, 2025
@robscott
Copy link
Member

Thanks @jsoref!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit d8f2a20 into kubernetes-sigs:main Feb 12, 2025
13 checks passed
@jsoref jsoref deleted the spelling branch February 12, 2025 18:44
EyalPazz pushed a commit to EyalPazz/gateway-api that referenced this pull request Feb 16, 2025
* spelling: adding

Signed-off-by: Josh Soref <[email protected]>

* spelling: anymore

Signed-off-by: Josh Soref <[email protected]>

* spelling: approach

Signed-off-by: Josh Soref <[email protected]>

* spelling: attached

Signed-off-by: Josh Soref <[email protected]>

* spelling: because

Signed-off-by: Josh Soref <[email protected]>

* spelling: cannot

Signed-off-by: Josh Soref <[email protected]>

* spelling: case-insensitive

Signed-off-by: Josh Soref <[email protected]>

* spelling: case-sensitive

Signed-off-by: Josh Soref <[email protected]>

* spelling: certificate

Signed-off-by: Josh Soref <[email protected]>

* spelling: certificates

Signed-off-by: Josh Soref <[email protected]>

* spelling: criteria

Signed-off-by: Josh Soref <[email protected]>

* spelling: deterministically

Signed-off-by: Josh Soref <[email protected]>

* spelling: discoverability

Signed-off-by: Josh Soref <[email protected]>

* spelling: docs

Signed-off-by: Josh Soref <[email protected]>

* spelling: encapsulated

Signed-off-by: Josh Soref <[email protected]>

* spelling: feature

Signed-off-by: Josh Soref <[email protected]>

* spelling: filesystem

Signed-off-by: Josh Soref <[email protected]>

* spelling: format

Signed-off-by: Josh Soref <[email protected]>

* spelling: frankbu

Signed-off-by: Josh Soref <[email protected]>

* spelling: github

Signed-off-by: Josh Soref <[email protected]>

* spelling: grpc

Signed-off-by: Josh Soref <[email protected]>

* spelling: grpcroute

Signed-off-by: Josh Soref <[email protected]>

* spelling: has

Signed-off-by: Josh Soref <[email protected]>

* spelling: have

Signed-off-by: Josh Soref <[email protected]>

* spelling: http-route

Signed-off-by: Josh Soref <[email protected]>

* spelling: httpproxy

Signed-off-by: Josh Soref <[email protected]>

* spelling: httpredirect

Signed-off-by: Josh Soref <[email protected]>

* spelling: https

Signed-off-by: Josh Soref <[email protected]>

* spelling: implementation

Signed-off-by: Josh Soref <[email protected]>

* spelling: improvements

Signed-off-by: Josh Soref <[email protected]>

* spelling: in

Signed-off-by: Josh Soref <[email protected]>

* spelling: infrastructure

Signed-off-by: Josh Soref <[email protected]>

* spelling: into

Signed-off-by: Josh Soref <[email protected]>

* spelling: intuitive

Signed-off-by: Josh Soref <[email protected]>

* spelling: its

Signed-off-by: Josh Soref <[email protected]>

* spelling: linked

Signed-off-by: Josh Soref <[email protected]>

* spelling: maintainers

Signed-off-by: Josh Soref <[email protected]>

* spelling: maintenance

Signed-off-by: Josh Soref <[email protected]>

* spelling: maximum

Signed-off-by: Josh Soref <[email protected]>

* spelling: negotiated

Signed-off-by: Josh Soref <[email protected]>

* spelling: networking

Signed-off-by: Josh Soref <[email protected]>

* spelling: nonexistent

Signed-off-by: Josh Soref <[email protected]>

* spelling: or

Signed-off-by: Josh Soref <[email protected]>

* spelling: overridden

Signed-off-by: Josh Soref <[email protected]>

* spelling: possible

Signed-off-by: Josh Soref <[email protected]>

* spelling: preexisting

Signed-off-by: Josh Soref <[email protected]>

* spelling: prominence

Signed-off-by: Josh Soref <[email protected]>

* spelling: protocol

Signed-off-by: Josh Soref <[email protected]>

* spelling: recommend

Signed-off-by: Josh Soref <[email protected]>

* spelling: referent

Signed-off-by: Josh Soref <[email protected]>

* spelling: release

Signed-off-by: Josh Soref <[email protected]>

* spelling: route-override

Signed-off-by: Josh Soref <[email protected]>

* spelling: stabilizing

Signed-off-by: Josh Soref <[email protected]>

* spelling: substituted

Signed-off-by: Josh Soref <[email protected]>

* spelling: targeting

Signed-off-by: Josh Soref <[email protected]>

* spelling: the

Signed-off-by: Josh Soref <[email protected]>

* spelling: validationutil

Signed-off-by: Josh Soref <[email protected]>

* spelling: which

Signed-off-by: Josh Soref <[email protected]>

* Reword simplify prototyping description

Signed-off-by: Josh Soref <[email protected]>

---------

Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants