-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published docs out of sync with comments in API definition #3401
Comments
/assign |
Hello @kundan2707, if you are not working on this issue. |
/assign @amitmaurya07 Please feel free. |
Thanks @youngnick |
/unassign |
@amitmaurya07 how are you going with this issue? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
FWIW #3400 made a change to |
Yes, checking the current docs, they correctly reflect that Service is also a supported parent. https://gateway-api.sigs.k8s.io/reference/spec/#parentreference I think we can close this one. @craigbox please comment if you don't agree and I'll reopen. /close |
@youngnick: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.ParentReference states
which has not been updated for the fact that in v1,
Service
is a supported parent also. This is correctly set in https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/shared_types.go#L23-L25, so perhaps the docs just need to be rebuilt?The text was updated successfully, but these errors were encountered: