Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s version in e2e tests #8503

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

dsimansk
Copy link
Contributor

Fixes #

Proposed Changes

  • Update k8s version in e2e tests

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Update k8s version in e2e tests

/cc @pierDipi @matzew

@knative-prow knative-prow bot requested review from matzew and pierDipi February 25, 2025 09:07
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (5bcee30) to head (17c58cb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8503      +/-   ##
==========================================
- Coverage   62.83%   62.81%   -0.02%     
==========================================
  Files         396      396              
  Lines       24233    24233              
==========================================
- Hits        15226    15223       -3     
- Misses       8199     8201       +2     
- Partials      808      809       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@pierDipi
Copy link
Member

/test unit-tests

Copy link

knative-prow bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor Author

@pierDipi I could also do a bit of overhaul to follow chainguard's action for kind setup. It's easier to bump version, since they maintain the mapping to images sha. :)

https://github.com/knative/serving/blob/87c07ee250da99e81cbe85a3c8690096782dc953/.github/workflows/kind-e2e.yaml#L172-L178

@pierDipi
Copy link
Member

@dsimansk that's interesting and definitely welcome

@knative-prow knative-prow bot merged commit 714deeb into knative:main Feb 25, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants