Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci exclude config #8502

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

pierDipi
Copy link
Member

Similar to Serving one knative/serving#15775

/cc @dsimansk

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested a review from dsimansk February 25, 2025 07:58
Copy link

knative-prow bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2025
@dsimansk
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@dsimansk
Copy link
Contributor

/retest

1 similar comment
@pierDipi
Copy link
Member Author

/retest

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (5bcee30) to head (c0011f3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8502      +/-   ##
==========================================
- Coverage   62.83%   62.81%   -0.02%     
==========================================
  Files         396      396              
  Lines       24233    24233              
==========================================
- Hits        15226    15223       -3     
- Misses       8199     8201       +2     
- Partials      808      809       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

dsimansk commented Feb 25, 2025

@pierDipi for the kind tests failures: #8503

Downstream eventing-github fix PR in go.mod is on they way to merge as well.

@knative-prow knative-prow bot merged commit 54a2402 into knative:main Feb 25, 2025
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants