-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial implementation of certmanager for integration sink #8481
Merged
knative-prow
merged 22 commits into
knative:main
from
matzew:integration_certmanager_raw
Feb 19, 2025
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ffc8377
Adding cert-mananger bits
matzew ba26ba5
Adding create cert manifest function
matzew 3c6a30a
Use the make cert
matzew 2df990c
Reconcile Certificate manifest and add RBAC
matzew f6fa1df
Add secret filter to controller
matzew cf0574d
Look up secrets/certs for sink
matzew 0d49024
Remove old/wrong Certificate manifest and reference
matzew c12dea3
Fix controller compile
matzew 6af8b8a
Formatting
matzew 31bf340
change the reconcile of cert manifest, and run it only w/ some form o…
matzew 3b6e31d
using filtered informer
matzew 5643b5e
Adding Rekt test for IntegrationSink TLS support
matzew b166f10
adding a bit of https port for deployment/service of the IntegrationSink
matzew d9b646e
Mounting secrets and setting quarkus env vars for TLS support
matzew a2909da
Adding flags for different TLS levels resulting in diffeerent quarkus…
matzew 5203878
Remove bad comment
matzew 5a235c1
Adding label
matzew 34b8cd2
Update codegen
matzew 7400edd
Disable tmp. the cert manager feature
matzew 3059b60
Fixing header/year
matzew 05de212
More test tweaking
matzew 5a0c1de
Remove unused and comment out the hooks for now
matzew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
pkg/client/certmanager/clientset/versioned/clientset.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If cert-manager is not installed, I think this logs errors and gets the controller stack on starting? Did you try that?
Also I don't think we need the
clusterissuer
,issuer
,challenge
, orcertificaterequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - forgot to comment that out