Partial implementation of certmanager for integration sink #8481

matzew · 2025-02-19T08:51:51Z

Proposed Changes

adding cert manager dependency and generating code
disabled it for now - but sharing for other parts to be able to use it

Next steps (or PRs)

isolate the "certmanager" library in a common place (so that event transformer can also "easily" use it
bump cert manager version and use their client set (like serving does)
Enable cert manager for integration sink and have dynamic knob for feature toggle (e.g. on/off)

Basics for Cert-manager Signed-off-by: Matthias Wessendorf <[email protected]>

Signed-off-by: Matthias Wessendorf <[email protected]>

…f TLS Signed-off-by: Matthias Wessendorf <[email protected]>

Signed-off-by: Matthias Wessendorf <[email protected]>

… env vars Signed-off-by: Matthias Wessendorf <[email protected]>

Signed-off-by: Matthias Wessendorf <[email protected]>

knative-prow · 2025-02-19T08:51:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Matthias Wessendorf <[email protected]>

codecov · 2025-02-19T09:18:32Z

Codecov Report

Attention: Patch coverage is 42.94872% with 89 lines in your changes missing coverage. Please review.

Project coverage is 62.64%. Comparing base (9a7c6d5) to head (5a0c1de).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...conciler/integration/sink/resources/certificate.go	0.00%	44 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go	31.42%	24 Missing ⚠️
...iler/integration/sink/resources/container_image.go	87.09%	7 Missing and 1 partial ⚠️
pkg/reconciler/integration/sink/controller.go	0.00%	6 Missing ⚠️
cmd/controller/main.go	0.00%	5 Missing ⚠️
pkg/reconciler/integration/sink/resources/names.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8481      +/-   ##
==========================================
- Coverage   62.77%   62.64%   -0.14%     
==========================================
  Files         395      397       +2     
  Lines       24108    24241     +133     
==========================================
+ Hits        15135    15185      +50     
- Misses       8166     8247      +81     
- Partials      807      809       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew · 2025-02-19T09:33:41Z

/test unit-tests

matzew · 2025-02-19T09:56:58Z

/test unit-tests

matzew · 2025-02-19T10:12:51Z

/retest

matzew · 2025-02-19T10:15:46Z

/test unit-tests

matzew · 2025-02-19T10:49:36Z

/test unit-tests

matzew · 2025-02-19T11:37:13Z

/test unit-tests

pierDipi · 2025-02-19T11:41:37Z

cmd/controller/main.go

+	for _, inf := range []injection.InformerInjector{challenge.WithInformer, v1certificate.WithInformer, certificaterequest.WithInformer, clusterissuer.WithInformer, issuer.WithInformer} {
+		injection.Default.RegisterInformer(inf)
+	}


If cert-manager is not installed, I think this logs errors and gets the controller stack on starting? Did you try that?

Also I don't think we need the clusterissuer, issuer, challenge, or certificaterequest

yeah - forgot to comment that out

config/core/roles/controller-clusterroles.yaml

Signed-off-by: Matthias Wessendorf <[email protected]>

pierDipi · 2025-02-19T13:20:39Z

/lgtm

matzew · 2025-02-19T13:45:25Z

/test unit-tests

matzew · 2025-02-19T14:03:09Z

/test unit-tests

) * Adding cert-mananger bits Basics for Cert-manager Signed-off-by: Matthias Wessendorf <[email protected]> * Adding create cert manifest function Signed-off-by: Matthias Wessendorf <[email protected]> * Use the make cert Signed-off-by: Matthias Wessendorf <[email protected]> * Reconcile Certificate manifest and add RBAC Signed-off-by: Matthias Wessendorf <[email protected]> * Add secret filter to controller Signed-off-by: Matthias Wessendorf <[email protected]> * Look up secrets/certs for sink Signed-off-by: Matthias Wessendorf <[email protected]> * Remove old/wrong Certificate manifest and reference Signed-off-by: Matthias Wessendorf <[email protected]> * Fix controller compile Signed-off-by: Matthias Wessendorf <[email protected]> * Formatting Signed-off-by: Matthias Wessendorf <[email protected]> * change the reconcile of cert manifest, and run it only w/ some form of TLS Signed-off-by: Matthias Wessendorf <[email protected]> * using filtered informer Signed-off-by: Matthias Wessendorf <[email protected]> * Adding Rekt test for IntegrationSink TLS support Signed-off-by: Matthias Wessendorf <[email protected]> * adding a bit of https port for deployment/service of the IntegrationSink Signed-off-by: Matthias Wessendorf <[email protected]> * Mounting secrets and setting quarkus env vars for TLS support Signed-off-by: Matthias Wessendorf <[email protected]> * Adding flags for different TLS levels resulting in diffeerent quarkus env vars Signed-off-by: Matthias Wessendorf <[email protected]> * Remove bad comment Signed-off-by: Matthias Wessendorf <[email protected]> * Adding label Signed-off-by: Matthias Wessendorf <[email protected]> * Update codegen Signed-off-by: Matthias Wessendorf <[email protected]> * Disable tmp. the cert manager feature Signed-off-by: Matthias Wessendorf <[email protected]> * Fixing header/year Signed-off-by: Matthias Wessendorf <[email protected]> * More test tweaking Signed-off-by: Matthias Wessendorf <[email protected]> * Remove unused and comment out the hooks for now Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]>

matzew added 19 commits February 18, 2025 17:40

Adding cert-mananger bits

ffc8377

Basics for Cert-manager Signed-off-by: Matthias Wessendorf <[email protected]>

Adding create cert manifest function

ba26ba5

Signed-off-by: Matthias Wessendorf <[email protected]>

Use the make cert

3c6a30a

Signed-off-by: Matthias Wessendorf <[email protected]>

Reconcile Certificate manifest and add RBAC

2df990c

Signed-off-by: Matthias Wessendorf <[email protected]>

Add secret filter to controller

f6fa1df

Signed-off-by: Matthias Wessendorf <[email protected]>

Look up secrets/certs for sink

cf0574d

Signed-off-by: Matthias Wessendorf <[email protected]>

Remove old/wrong Certificate manifest and reference

0d49024

Signed-off-by: Matthias Wessendorf <[email protected]>

Fix controller compile

c12dea3

Signed-off-by: Matthias Wessendorf <[email protected]>

Formatting

6af8b8a

Signed-off-by: Matthias Wessendorf <[email protected]>

change the reconcile of cert manifest, and run it only w/ some form o…

31bf340

…f TLS Signed-off-by: Matthias Wessendorf <[email protected]>

using filtered informer

3b6e31d

Signed-off-by: Matthias Wessendorf <[email protected]>

Adding Rekt test for IntegrationSink TLS support

5643b5e

Signed-off-by: Matthias Wessendorf <[email protected]>

adding a bit of https port for deployment/service of the IntegrationSink

b166f10

Signed-off-by: Matthias Wessendorf <[email protected]>

Mounting secrets and setting quarkus env vars for TLS support

d9b646e

Signed-off-by: Matthias Wessendorf <[email protected]>

Adding flags for different TLS levels resulting in diffeerent quarkus…

a2909da

… env vars Signed-off-by: Matthias Wessendorf <[email protected]>

Remove bad comment

5203878

Signed-off-by: Matthias Wessendorf <[email protected]>

Adding label

5a235c1

Signed-off-by: Matthias Wessendorf <[email protected]>

Update codegen

34b8cd2

Signed-off-by: Matthias Wessendorf <[email protected]>

Disable tmp. the cert manager feature

7400edd

Signed-off-by: Matthias Wessendorf <[email protected]>

knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Feb 19, 2025

knative-prow bot requested review from mgencur and pierDipi February 19, 2025 08:51

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2025

matzew added 2 commits February 19, 2025 09:58

Fixing header/year

3059b60

Signed-off-by: Matthias Wessendorf <[email protected]>

More test tweaking

05de212

Signed-off-by: Matthias Wessendorf <[email protected]>

pierDipi reviewed Feb 19, 2025

View reviewed changes

config/core/roles/controller-clusterroles.yaml Outdated Show resolved Hide resolved

Remove unused and comment out the hooks for now

5a0c1de

Signed-off-by: Matthias Wessendorf <[email protected]>

knative-prow bot assigned pierDipi Feb 19, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025

knative-prow bot merged commit 732ec62 into knative:main Feb 19, 2025
30 of 36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial implementation of certmanager for integration sink #8481

Partial implementation of certmanager for integration sink #8481

matzew commented Feb 19, 2025

knative-prow bot commented Feb 19, 2025

codecov bot commented Feb 19, 2025 •

edited

Loading

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

pierDipi Feb 19, 2025

matzew Feb 19, 2025

pierDipi commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

Partial implementation of certmanager for integration sink #8481

Partial implementation of certmanager for integration sink #8481

Conversation

matzew commented Feb 19, 2025

Proposed Changes

Next steps (or PRs)

knative-prow bot commented Feb 19, 2025

codecov bot commented Feb 19, 2025 • edited Loading

Codecov Report

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

pierDipi Feb 19, 2025

Choose a reason for hiding this comment

matzew Feb 19, 2025

Choose a reason for hiding this comment

pierDipi commented Feb 19, 2025

matzew commented Feb 19, 2025

matzew commented Feb 19, 2025

codecov bot commented Feb 19, 2025 •

edited

Loading