Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial implementation of certmanager for integration sink #8481

Merged
merged 22 commits into from
Feb 19, 2025

Remove unused and comment out the hooks for now

5a0c1de
Select commit
Loading
Failed to load commit list.
Merged

Partial implementation of certmanager for integration sink #8481

Remove unused and comment out the hooks for now
5a0c1de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 19, 2025 in 0s

62.64% (-0.14%) compared to 9a7c6d5

View this Pull Request on Codecov

62.64% (-0.14%) compared to 9a7c6d5

Details

Codecov Report

Attention: Patch coverage is 42.94872% with 89 lines in your changes missing coverage. Please review.

Project coverage is 62.64%. Comparing base (9a7c6d5) to head (5a0c1de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...conciler/integration/sink/resources/certificate.go 0.00% 44 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go 31.42% 24 Missing ⚠️
...iler/integration/sink/resources/container_image.go 87.09% 7 Missing and 1 partial ⚠️
pkg/reconciler/integration/sink/controller.go 0.00% 6 Missing ⚠️
cmd/controller/main.go 0.00% 5 Missing ⚠️
pkg/reconciler/integration/sink/resources/names.go 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8481      +/-   ##
==========================================
- Coverage   62.77%   62.64%   -0.14%     
==========================================
  Files         395      397       +2     
  Lines       24108    24241     +133     
==========================================
+ Hits        15135    15185      +50     
- Misses       8166     8247      +81     
- Partials      807      809       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov