refactor: use jsonnet render engine in go binary #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
Sep 20, 2023
| return nil | ||
| } | ||
|
|
||
| if err := root.Execute(); err != nil { | ||
| log.Fatalln(err) | ||
| } | ||
| } | ||
|
|
||
| // importer wraps jsonnet.FileImporter |
There was a problem hiding this comment.
This part is copied from pkg/docsonnet/load.go.
Duologic
commented
Sep 20, 2023
Comment on lines
+59
to
+68
| for k, v := range output { | ||
| fullpath := filepath.Join(*dir, k) | ||
| dir := filepath.Dir(fullpath) | ||
| if err := os.MkdirAll(dir, os.ModePerm); err != nil { | ||
| return err | ||
| } | ||
| if err := os.WriteFile(fullpath, []byte(v), 0644); err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
This part is copied from pkg/render/render.go.
This was referenced Sep 20, 2023
|
While running this against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Go implementation of the render engine and replacing it by simply invoking the jsonnet code from doc-util in a Jsonnet VM.
This'll get rid of the diverging behavior in rendering engines and reduce toil on maintenance while still providing a binary for those that prefer that.
This also removes the option show the Package data as JSON, I believe they mostly existed to debug the Extract and Transform functions of the go code.
Considering the low number of lines (~100), I've also dropped everything in main.go.
Fixes #35
Replaces #37
Replaces #39
This PR takes a very similar approach as #39 but far more destructive as it doesn't intend to maintain the Go version.
In #39, @yorinasub17 suggests that it hits a max-stack-frames on (tf-libsonnet/hashicorp-aws), I was not able to reproduce that with this PR. Performance wise it was terribly slow, I've ran the same code with
jrsonnet(rust version) and that was magnitudes faster (~40x) and didn't burn up my CPU. So perhaps it would be beneficial to use the jrsonnet C bindings here instead of the native Go implementation (next PR?).I've also resolved the
./render.libsonnetimport with a simple strings.ReplaceAll on themain.libsonnet, embedding the whole thing.