docsonnet go bin: Switch from pkger to embed #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
changed the title
Duologic
approved these changes
Dec 20, 2022
|
Hmm, I see the docker pipeline fail, I assume the credentials used were from @sh0rez and he changed them now. |
|
Now that we've switched to goreleaser, mind doing a rebase of this PR? |
yorinasub17
force-pushed
the
feature/go-embed
branch
from
2f21f9e
to
f3b260c
Compare
|
@Duologic Done! |
yorinasub17
force-pushed
the
feature/go-embed
branch
from
b83fa81
to
9861749
Compare
Signed-off-by: Yoriyasu Yano <[email protected]>
yorinasub17
force-pushed
the
feature/go-embed
branch
from
9861749
to
a35a0fa
Compare
|
Closing as superseded by #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This updates the static file embedding logic to use the builtin embed instead of
pkger, which has the advantage of dynamically embedding without code generation. This means that there is no need to maintain a separatepkged.gofile every timedoc-utilorload.libsonnetis updated, as the latest version is always embedded even when installingdocsonnetwithgo install.Side note: I am aware from reading the issue that the fate of the go binary is in the air. Personally, I like the
docsonnetgo binary as it makes for a very quick installation process and keeps the source jsonnet libraries "clean" by reducing the number of entrypoints. Regardless, thought it made sense to update it for others who run into issues trying to use it.