Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate aggregated javadoc for **.internal.** packages #12778

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

olamy
Copy link
Member

@olamy olamy commented Feb 7, 2025

Signed-off-by: Olivier Lamy [email protected]

@olamy olamy self-assigned this Feb 7, 2025
@olamy olamy requested a review from joakime February 7, 2025 04:09
@joakime
Copy link
Contributor

joakime commented Feb 7, 2025

Is this configuration enough so that the javadoc classified artifacts generated by the release process also do not include *.internal.* class references?

Example: jetty-server has 3 internal classes.
Those shouldn't be present in jetty-server-<ver>-javadoc.jar

@joakime joakime merged commit 880f82c into jetty-12.0.x Feb 7, 2025
10 checks passed
@joakime joakime deleted the jetty-12.0.x-javadoc-skip-internal-package branch February 7, 2025 16:01
@olamy
Copy link
Member Author

olamy commented Feb 8, 2025

Is this configuration enough so that the javadoc classified artifacts generated by the release process also do not include *.internal.* class references?

Example: jetty-server has 3 internal classes. Those shouldn't be present in jetty-server-<ver>-javadoc.jar

explained here #12620 (comment) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants