Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated javadoc is now working without hack #12620

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

olamy
Copy link
Member

@olamy olamy commented Dec 9, 2024

Signed-off-by: Olivier Lamy [email protected]

@olamy
Copy link
Member Author

olamy commented Dec 9, 2024

@joakime you can test with

mvn clean install -DskipTests  -Pjavadoc-aggregate javadoc:aggregate

sbordet
sbordet previously approved these changes Feb 5, 2025
@olamy olamy force-pushed the jetty-12.0.x-aggregated-javadoc branch from 988e552 to 54271b8 Compare February 5, 2025 22:00
@olamy olamy requested review from sbordet and joakime February 6, 2025 01:40
@joakime joakime merged commit c371445 into jetty-12.0.x Feb 6, 2025
10 checks passed
@joakime joakime deleted the jetty-12.0.x-aggregated-javadoc branch February 6, 2025 14:52
@joakime
Copy link
Contributor

joakime commented Feb 6, 2025

@olamy now we need a followup PR that excludes the package pattern *.internal.* and *.internal from generating javadoc, even in non-aggregate mode.

@olamy
Copy link
Member Author

olamy commented Feb 7, 2025

@olamy now we need a followup PR that excludes the package pattern *.internal.* and *.internal from generating javadoc, even in non-aggregate mode.

here you go #12778

no need to exclude for non aggregated javadoc as it is not generated.
When used standard jmps mode, javadoc contains only packages from module-info.java which are exported.
see https://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-client/12.0.16/jetty-client-12.0.16-sources.jar or https://repo.maven.apache.org/maven2/org/eclipse/jetty/http3/jetty-http3-common/12.0.16/jetty-http3-common-12.0.16-sources.jar they do not have *.internal.* packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants