Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove extra Error from the message #905

Merged
merged 2 commits into from
Feb 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/datachain/catalog/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@
PULL_DATASET_CHECK_STATUS_INTERVAL = 20 # interval to check export status in Studio


def raise_remote_error(error_message: str) -> NoReturn:
raise DataChainError(f"Error from server: {error_message}")


def noop(_: str):
pass

Expand Down Expand Up @@ -211,14 +207,14 @@
self.remote_ds_name, self.remote_ds_version
)
if not export_status_response.ok:
raise_remote_error(export_status_response.message)
raise DataChainError(export_status_response.message)

Check warning on line 210 in src/datachain/catalog/catalog.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/catalog/catalog.py#L210

Added line #L210 was not covered by tests

export_status = export_status_response.data["status"] # type: ignore [index]

if export_status == "failed":
raise_remote_error("Dataset export failed in Studio")
raise DataChainError("Dataset export failed in Studio")
if export_status == "removed":
raise_remote_error("Dataset export removed in Studio")
raise DataChainError("Dataset export removed in Studio")

self.last_status_check = time.time()

Expand Down Expand Up @@ -1113,7 +1109,7 @@

info_response = studio_client.dataset_info(name)
if not info_response.ok:
raise_remote_error(info_response.message)
raise DataChainError(info_response.message)

dataset_info = info_response.data
assert isinstance(dataset_info, dict)
Expand Down Expand Up @@ -1409,7 +1405,7 @@
remote_ds_name, remote_ds_version.version
)
if not export_response.ok:
raise_remote_error(export_response.message)
raise DataChainError(export_response.message)

Check warning on line 1408 in src/datachain/catalog/catalog.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/catalog/catalog.py#L1408

Added line #L1408 was not covered by tests

signed_urls = export_response.data

Expand Down
17 changes: 8 additions & 9 deletions src/datachain/studio.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import sys
from typing import TYPE_CHECKING, Optional

from datachain.catalog.catalog import raise_remote_error
from datachain.config import Config, ConfigLevel
from datachain.dataset import QUERY_DATASET_PREFIX
from datachain.error import DataChainError
Expand Down Expand Up @@ -150,7 +149,7 @@
response = client.ls_datasets()

if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 152 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L152

Added line #L152 was not covered by tests

if not response.data:
return
Expand All @@ -171,7 +170,7 @@
response = client.dataset_info(name)

if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 173 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L173

Added line #L173 was not covered by tests

if not response.data:
return
Expand All @@ -191,7 +190,7 @@
client = StudioClient(team=team_name)
response = client.edit_dataset(name, new_name, description, labels)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 193 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L193

Added line #L193 was not covered by tests

print(f"Dataset '{name}' updated in Studio")

Expand All @@ -205,7 +204,7 @@
client = StudioClient(team=team_name)
response = client.rm_dataset(name, version, force)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 207 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L207

Added line #L207 was not covered by tests

print(f"Dataset '{name}' removed from Studio")

Expand Down Expand Up @@ -235,7 +234,7 @@

response = client.dataset_job_versions(job_id)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 237 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L237

Added line #L237 was not covered by tests

response_data = response.data
if response_data:
Expand Down Expand Up @@ -286,7 +285,7 @@
requirements=requirements,
)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 288 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L288

Added line #L288 was not covered by tests

if not response.data:
raise DataChainError("Failed to create job")
Expand All @@ -307,7 +306,7 @@
file_content = f.read()
response = client.upload_file(file_content, file_name)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 309 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L309

Added line #L309 was not covered by tests

if not response.data:
raise DataChainError(f"Failed to upload file {file_name}")
Expand All @@ -328,7 +327,7 @@
client = StudioClient(team=team_name)
response = client.cancel_job(job_id)
if not response.ok:
raise_remote_error(response.message)
raise DataChainError(response.message)

Check warning on line 330 in src/datachain/studio.py

View check run for this annotation

Codecov / codecov/patch

src/datachain/studio.py#L330

Added line #L330 was not covered by tests

print(f"Job {job_id} canceled")

Expand Down
6 changes: 2 additions & 4 deletions tests/func/test_pull.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def test_pull_dataset_not_found_in_remote(

with pytest.raises(DataChainError) as exc_info:
catalog.pull_dataset("ds://dogs@v1")
assert str(exc_info.value) == "Error from server: Dataset not found"
assert str(exc_info.value) == "Dataset not found"


@pytest.mark.parametrize("cloud_type, version_aware", [("s3", False)], indirect=True)
Expand All @@ -332,9 +332,7 @@ def test_pull_dataset_exporting_dataset_failed_in_remote(

with pytest.raises(DataChainError) as exc_info:
catalog.pull_dataset("ds://dogs@v1")
assert str(exc_info.value) == (
f"Error from server: Dataset export {export_status} in Studio"
)
assert str(exc_info.value) == f"Dataset export {export_status} in Studio"


@pytest.mark.parametrize("cloud_type, version_aware", [("s3", False)], indirect=True)
Expand Down