Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove extra Error from the message #905

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

shcheklein
Copy link
Member

Instead of:

(.venv) √ Projects/cattle-care-train % datachain ds pull ds://something
Error: Error from server: Dataset something not found

we now do:

(.venv) √ Projects/cattle-care-train % datachain ds pull ds://something
Error: Dataset something not found

I think this should be enough

Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d6414e
Status: ✅  Deploy successful!
Preview URL: https://cbfd7f56.datachain-documentation.pages.dev
Branch Preview URL: https://fix-minor-cli-message-fix.datachain-documentation.pages.dev

View logs

@shcheklein shcheklein force-pushed the fix/minor-cli-message-fix branch 4 times, most recently from 00c1c64 to 0c13072 Compare February 8, 2025 04:51
@shcheklein shcheklein force-pushed the fix/minor-cli-message-fix branch from 0c13072 to 1746f83 Compare February 8, 2025 04:59
@shcheklein shcheklein requested review from amritghimire and a team February 8, 2025 05:03
@shcheklein shcheklein self-assigned this Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (79f6cf9) to head (7d6414e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/studio.py 0.00% 8 Missing ⚠️
src/datachain/catalog/catalog.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   87.69%   88.06%   +0.36%     
==========================================
  Files         130      129       -1     
  Lines       11664    11367     -297     
  Branches     1586     1541      -45     
==========================================
- Hits        10229    10010     -219     
+ Misses       1038      968      -70     
+ Partials      397      389       -8     
Flag Coverage Δ
datachain 87.98% <23.07%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/func/test_pull.py Outdated Show resolved Hide resolved
@shcheklein shcheklein merged commit 03d7440 into main Feb 8, 2025
36 of 37 checks passed
@shcheklein shcheklein deleted the fix/minor-cli-message-fix branch February 8, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants