gateway api: fix rewrite #54939
Draft
gateway api: fix rewrite #54939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
istio-testing
added
do-not-merge/work-in-progress
howardjohn
force-pushed
the
gtw/prefix-match-fix
branch
from
abf4a6b to
854b081
Compare
Stevenjin8
reviewed
Feb 4, 2025
| rewrite.Uri = strings.TrimSuffix(*filter.Path.ReplacePrefixMatch, "/") | ||
| if rewrite.Uri == "" { | ||
| // `/` means removing the prefix | ||
| rewrite.Uri = "/" | ||
| } else if prefixMatchAll { | ||
| rewrite.UriRegexRewrite = &istio.RegexRewrite{ |
There was a problem hiding this comment.
So we're using regex matching over standard matching to get around envoy?
There was a problem hiding this comment.
yep. I don't love it -- we can see about getting afix into envoy itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54920
Please provide a description of this PR: