Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplacePrefixMatch in the URLRewrite filter does not handle empty match prefix correctly #5256

Open
sadovnikov opened this issue Feb 11, 2025 · 3 comments
Labels
help wanted Extra attention is needed kind/bug Something isn't working
Milestone

Comments

@sadovnikov
Copy link
Contributor

Description:

In its examples, the Gateway API uses "foo" in "Prefix Match". However, we can conclude that the HTTPPathModifier should also work on / as the path prefix match.

The PR #5254 PR demonstrates that / is not handled correctly.

Repro steps:

Follow the end-2-end test, which is added in #5254

Environment:

In our environment, we use docker.io/envoyproxy/gateway:v1.3.0. The bug is reproducible in the main branch, and is reproducible in v1.2.5

@arkodg
Copy link
Contributor

arkodg commented Feb 11, 2025

relates to kubernetes-sigs/gateway-api#3592

we've had some issues in this area

hoping someone can help with ironing this out

@arkodg arkodg added kind/bug Something isn't working help wanted Extra attention is needed and removed triage labels Feb 11, 2025
@arkodg arkodg added this to the v1.4.0-rc.1 milestone Feb 11, 2025
@arkodg
Copy link
Contributor

arkodg commented Feb 11, 2025

cc @zhaohuabing @LiorLieberman

@LiorLieberman
Copy link
Contributor

Are we good to employ istio/istio#54939?

Will also start a discussion in slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants