Skip to content

Collision Mesh Schema Additions #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hapatel-bdai
Copy link
Collaborator

NOTE:

- Please approve the added script to convert urdfs/meshes to instanceable USD in batches #2248 first

- The exception if type(obj).__name__ == "MeshConverterCfg": return missing_fields is required to get around how the collision mesh schema is setup

Description

Adding new collision mesh property options allowing users to configure meshes to add different collision types

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Added to contributors list

Signed-off-by: Harsh Patel <[email protected]>
Copy link
Collaborator

@jsmith-bdai jsmith-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

See :meth:`set_mesh_collision_properties` for more information.

.. note::
If the values are None, they are not modified. This is useful when you want to set only a subset of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the values are None, they are not modified. This is useful when you want to set only a subset of
If the values are MISSING, they are not modified. This is useful when you want to set only a subset of

@@ -47,7 +47,7 @@ def configclass(cls, **kwargs):

from dataclasses import MISSING

from isaaclab.utils.configclass import configclass
from isaaclabz.utils.configclass import configclass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💤

Suggested change
from isaaclabz.utils.configclass import configclass
from isaaclab.utils.configclass import configclass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants