Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-select): fix select's dropdown border radius #1860

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Feb 4, 2025

TEST PLAN: check if the bottom of select's dropdown and the option list has the same border radius

closes: INSTUI-4442

@HerrTopi HerrTopi requested review from matyasf and ToMESSKa February 4, 2025 18:55
Copy link

github-actions bot commented Feb 4, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-14 09:50 UTC

@matyasf
Copy link
Collaborator

matyasf commented Feb 10, 2025

There is a narrow white part between the item's selection and the border, I wonder if it can be fixed. Its more visible with more rounded corners, e.g.

<InstUISettingsProvider
  theme={{
        componentOverrides: {
          View: {borderRadiusMedium: '2rem'}
        }
  }}
>
  <SimpleSelect renderLabel="Uncontrolled Select" >
    <SimpleSelect.Option id="foo" value="foo"
                         renderBeforeLabel={(props) => {
                           return <IconCheckSolid />
                         }}>
      Foo
    </SimpleSelect.Option>
    <SimpleSelect.Option id="bar" value="bar">
      Bar
    </SimpleSelect.Option>
    <SimpleSelect.Option id="baz" value="baz">
      Baz
    </SimpleSelect.Option>
  </SimpleSelect>
</InstUISettingsProvider>
image

@matyasf matyasf merged commit 7427773 into master Feb 14, 2025
11 checks passed
@matyasf matyasf deleted the fix-select-borderradius branch February 14, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants