-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-popover, ui-select): allow overriding Select's dropdown border #1862
base: master
Are you sure you want to change the base?
feat(ui-popover, ui-select): allow overriding Select's dropdown border #1862
Conversation
|
8775cd7
to
9c06820
Compare
* | ||
* Accepts the familiar CSS shorthand to designate border widths corresponding to edges. (e.g. 'none large none large). | ||
* | ||
* Only applies to a Popover without an arrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I inserted this about the no arrow version, because the arrow version uses ContextView which would result in having to rewrite ContextView too unfortunately.
So as I see one can now use this prop and after merging #1860 the border radius will work nice too. This is the sample code that they need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment above, it good to go from me
bb81af9
to
4fb057c
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, LGTM 👍
Closes: INSTUI-4395
ISUUE: the border of Select's dropdown cannot be overridden now. CLX team need a version without borders. The border radius need to be changed too, but that can be done with a InstUISettingsProvider.
TEST PLAN: