Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset StateBatchScheduler state on error. #360

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Reset StateBatchScheduler state on error. #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions formula/src/main/java/com/instacart/formula/batch/StateBatchScheduler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,21 @@ class StateBatchScheduler : BatchScheduler {
}

isUpdating.set(true)
update()
isUpdating.remove()
try {
update()
} finally {
isUpdating.remove()

// Get collected batches
val batches: MutableSet<BatchScheduler.Batch>? = threadLocalBatches.get()
// Clear them from our state
threadLocalBatches.remove()
// Get collected batches
val batches: MutableSet<BatchScheduler.Batch>? = threadLocalBatches.get()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We clear try to close out open batches even if there was an error

// Clear them from our state
threadLocalBatches.remove()

// Execute them
if (batches != null) {
for(batch in batches) {
batch.execute()
// Execute them
if (batches != null) {
for(batch in batches) {
batch.execute()
}
}
}
}
Expand Down
Loading