Reset StateBatchScheduler state on error. #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
force-pushed
the
laimonas/reset-scheduler-state-on-error
branch
from
687c964 to
314f127
Compare
Laimiux
commented
Mar 18, 2024
| // Clear them from our state | ||
| threadLocalBatches.remove() | ||
| // Get collected batches | ||
| val batches: MutableSet<BatchScheduler.Batch>? = threadLocalBatches.get() |
There was a problem hiding this comment.
We clear try to close out open batches even if there was an error
JaCoCo Code Coverage 83.63% ✅
Generated by 🚫 Danger |
jasonostrander
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.