🚦 Mise en place de deux domaines sur toute la stack : locale, CI, staging #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
2423f68 to
792e8b3
Compare
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
1db85d8 to
39e8084
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
2d4ea2a to
f9606fa
Compare
fabienheureux
changed the title
6 tasks
fabienheureux
requested review from
kolok and
maxcorbeau
and removed request for
a team
fabienheureux
commented
Feb 18, 2025
fabienheureux
commented
Feb 18, 2025
fabienheureux
commented
Feb 18, 2025
.github/workflows/run_tests.yml
Outdated
Comment on lines
94
to
104
| - name: Add hosts to /etc/hosts | ||
| run: | | ||
| sudo echo "127.0.0.1 lvao.dev" | sudo tee -a /etc/hosts | ||
| - run: >- | ||
| docker run -d -p 80:80 | ||
| -v ${{ github.workspace }}/nginx/servers.conf:/etc/nginx/servers.conf:ro | ||
| -v ${{ github.workspace }}/nginx/certs:/etc/nginx/ssl | ||
| --add-host=host.docker.internal:host-gateway | ||
| -e GITHUB_ACTIONS=true -e CI=true nginx:1.18 | ||
| # --health-cmd "curl -fs https://assistant.dev" | ||
| # --health-interval 2s --health-timeout 5s --health-retries 5 |
There was a problem hiding this comment.
dysfonctionnel, à finir à mon retour de vacances
fabienheureux
commented
Feb 18, 2025
nginx/certs/assistant.dev+1-key.pem
Outdated
There was a problem hiding this comment.
à supprimer du repo
fabienheureux
commented
Feb 18, 2025
nginx/servers.conf
Outdated
There was a problem hiding this comment.
voir pour mutualiser les deux confs
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
d24f467 to
791a85e
Compare
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
3 times, most recently
from
e92a614 to
fe58963
Compare
maxcorbeau
approved these changes
Feb 19, 2025
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
98ed192 to
dc68ed3
Compare
fabienheureux
force-pushed
the
improve-dual-domain-setup
branch
from
dc68ed3 to
de59458
Compare
fabienheureux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
En lien avec https://www.notion.so/accelerateur-transition-ecologique-ademe/Si-iFram-et-que-je-clique-dans-une-fiche-produit-sur-le-logo-a-revient-la-page-d-accueil-mais-av-17b6523d57d7800ea4dbe206b5af86b5?pvs=4
🗺️ contexte: on utilise deux domaines en prod, on souhaite répliquer ce système
💡 quoi: définition de domaines assistant.dev et lvao.dev pour atteindre les webapps en local
🎯 pourquoi:
🤔 comment:
Note : j'en ai profité pour ajouter un lancement conditionnel des test e2e, en la présence du tag
frontendils se lanceront.Sur MacOS il peut être requis de rafraîchir des choses :
Auto-review
Les trucs à faire avant de demander une review :
.env.template✅ Reste à faire (PR en cours)
📆 A faire (prochaine PR)