🖼️ Appeler iframeResize après le chargement effectif de l'iframe dans le parent #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienheureux
commented
Feb 17, 2025
fabienheureux
commented
Feb 17, 2025
fabienheureux
requested review from
kolok and
maxcorbeau
and removed request for
a team
fabienheureux
changed the title
fabienheureux
commented
Feb 17, 2025
fabienheureux
changed the title
fabienheureux
force-pushed
the
debug-iframes-post-mep
branch
2 times, most recently
from
d0c6261 to
459f204
Compare
kolok
force-pushed
the
debug-iframes-post-mep
branch
from
459f204 to
272fe1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Carte Notion/Mattermost/Sentry : https://www.notion.so/accelerateur-transition-ecologique-ademe/IFRAME-Probl-mes-restants-sur-les-iFrames-suite-MEP-hors-Ecologie-gouv-Investigation-1996523d57d780d5a4c9c9f289da9847?pvs=4
🗺️ contexte: post mise en production assistant v2
💡 quoi: modification de la manière dont les iframes se redimensionnent
🎯 pourquoi: les iframes se dimensionnent mal sur certains réutilisateurs
🤔 comment: on s'assure que l'iframe ait envoyé l'événement "load" avant de déclencher son resize.
Exemple résultats / UI / Data
Note : les tests locaux ne sont pas forcément iso avec les modes de survenue du bug en production.
J'ai tenté de reproduire ses conditions d'execution mais il est probable que le bug vienne d'autres causes, auquel cas ce correctif nécessitera p-e des ajustements
En local - AVANT
En local - APRÈS
Auto-review
Les trucs à faire avant de demander une review :
.env.template✅ Reste à faire (PR en cours)
📆 A faire (prochaine PR)