Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bearing Formats #343

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Bearing Formats #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SchemaInventory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"name": "Formats",
"path": "System\\Formats.ecschema.xml",
"released": false,
"version": "01.00.00",
"version": "01.00.01",
"comment": "Working Copy",
"sha1": "",
"author": "",
Expand Down
12 changes: 10 additions & 2 deletions System/Formats.ecschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
| * Copyright (c) Bentley Systems, Incorporated. All rights reserved.
| * See LICENSE.md in the project root for license terms and full copyright notice.
======================================================================================= -->
<ECSchema schemaName="Formats" alias="f" version="01.00.00" description="Standard Set of Format definitions" xmlns="http://www.bentley.com/schemas/Bentley.ECXML.3.2">
<ECSchemaReference name="Units" version="01.00.00" alias="u"/>
<ECSchema schemaName="Formats" alias="f" version="01.00.01" description="Standard Set of Format definitions" xmlns="http://www.bentley.com/schemas/Bentley.ECXML.3.2">
<ECSchemaReference name="Units" version="01.00.09" alias="u"/>

<Format typeName="DefaultReal" displayLabel="real" type="decimal" precision="6" formatTraits="keepSingleZero|keepDecimalPoint"/>
<Format typeName="DefaultRealU" displayLabel="realu" type="decimal" precision="6" formatTraits="keepSingleZero|keepDecimalPoint|showUnitLabel"/>
Expand Down Expand Up @@ -50,4 +50,12 @@
<Unit label="sec">u:S</Unit>
</Composite>
</Format>

<Format typeName="BearingDMS" displayLabel="Degrees Minutes Seconds" type="Bearing" precision="0" uomSeparator="" revolutionUnit="u:BEARING_REVOLUTION" formatTraits="showUnitLabel">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I just noticed this PR. This is not going to work at the moment. The new formats support is just built into the core-quantity package and native units framework. Supporting it inside an ECSchema is a different deal. @ColinKerr: I think this may even require Rohit's backwards-compatibility changes to roll out before we can add something like this, as the new type would not be handled by older code.

<Composite spacer="" includeZero="true">
<Unit label="&#176;">u:BEARING_ARC_DEG</Unit>
<Unit label="'">u:BEARING_ARC_MINUTE</Unit>
<Unit label="&quot;">u:BEARING_ARC_SECOND</Unit>
</Composite>
</Format>
</ECSchema>
Loading