Bearing Formats #343
Draft
Bearing Formats #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschili
reviewed
Sep 18, 2024
| @@ -50,4 +50,12 @@ | |||
| <Unit label="sec">u:S</Unit> | |||
| </Composite> | |||
| </Format> | |||
|
|
|||
| <Format typeName="BearingDMS" displayLabel="Degrees Minutes Seconds" type="Bearing" precision="0" uomSeparator="" revolutionUnit="u:BEARING_REVOLUTION" formatTraits="showUnitLabel"> | |||
There was a problem hiding this comment.
Oh I just noticed this PR. This is not going to work at the moment. The new formats support is just built into the core-quantity package and native units framework. Supporting it inside an ECSchema is a different deal. @ColinKerr: I think this may even require Rohit's backwards-compatibility changes to roll out before we can add something like this, as the new type would not be handled by older code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.