fix: bug in proactive rescheduling not accounting for future timeout (#…

…434)
hypertrace · Oct 18, 2023 · 2ca25ad · 2ca25ad
1 parent 3939ffc
commit 2ca25ad
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java b/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
@@ -175,12 +175,12 @@ public void process(Record<TraceIdentity, RawSpan> record) {
       traceEmitPunctuator.scheduleTask(currentTimeMs, key);
     } else {
       traceState.getSpanIds().add(spanId);
-      long prevScheduleTimestamp = traceState.getTraceEndTimestamp();
+      long prevScheduleTimestamp = traceState.getTraceEndTimestamp() + groupingWindowTimeoutMs;
       traceState.setTraceEndTimestamp(currentTimeMs);
       if (!traceEmitPunctuator.rescheduleTask(
           prevScheduleTimestamp, currentTimeMs + groupingWindowTimeoutMs, key)) {
         logger.debug(
-            "Failed to reschedule task on getting span for trace key {}, schedule already dropped!",
+            "Failed to proactively reschedule task on getting span for trace key {}, schedule already dropped!",
             key);
       }
     }