fix: clean up list interface and mistake in store builder (#433)

hypertrace · Oct 18, 2023 · 3939ffc · 3939ffc
1 parent 4433123
commit 3939ffc
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 7 deletions.
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -3,7 +3,7 @@ hypertrace-entity-service = "0.8.78"
 hypertrace-config-service = "0.1.54"
 hypertrace-grpc-utils = "0.12.4"
 hypertrace-serviceFramework = "0.1.60"
-hypertrace-kafkaStreams = "0.4.0"
+hypertrace-kafkaStreams = "0.4.1"
 hypertrace-view-generator = "0.4.19"
 grpc = "1.57.2"
 

diff --git a/.../raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansGrouper.java b/.../raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansGrouper.java
@@ -86,7 +86,7 @@ StreamsBuilder buildTopologyWithClock(
                 Stores.persistentKeyValueStore(SPAN_STATE_STORE_NAME), keySerde, valueSerde)
             .withCachingEnabled();
 
-    StoreBuilder<KeyValueStore<Long, TraceIdentity>> traceEmitPunctuatorStoreBuilder =
+    StoreBuilder<KeyValueStore<Long, List<TraceIdentity>>> traceEmitPunctuatorStoreBuilder =
         Stores.keyValueStoreBuilder(
                 Stores.persistentKeyValueStore(TRACE_EMIT_PUNCTUATOR_STORE_NAME),
                 Serdes.Long(),

diff --git a/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java b/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
@@ -23,7 +23,6 @@
 import java.time.Clock;
 import java.time.Duration;
 import java.time.Instant;
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -112,7 +111,7 @@ public void init(ProcessorContext<TraceIdentity, StructuredTrace> context) {
       defaultMaxSpanCountLimit = jobConfig.getLong(DEFAULT_INFLIGHT_TRACE_MAX_SPAN_COUNT);
     }
 
-    KeyValueStore<Long, ArrayList<TraceIdentity>> traceEmitPunctuatorStore =
+    KeyValueStore<Long, List<TraceIdentity>> traceEmitPunctuatorStore =
         context.getStateStore(TRACE_EMIT_PUNCTUATOR_STORE_NAME);
     traceEmitPunctuator =
         new TraceEmitPunctuator(

diff --git a/...-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/TraceEmitPunctuator.java b/...-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/TraceEmitPunctuator.java
@@ -77,7 +77,7 @@ class TraceEmitPunctuator extends AbstractThrottledPunctuator<TraceIdentity> {
 
   TraceEmitPunctuator(
       ThrottledPunctuatorConfig throttledPunctuatorConfig,
-      KeyValueStore<Long, ArrayList<TraceIdentity>> throttledPunctuatorStore,
+      KeyValueStore<Long, List<TraceIdentity>> throttledPunctuatorStore,
       ProcessorContext<TraceIdentity, StructuredTrace> context,
       KeyValueStore<SpanIdentity, RawSpan> spanStore,
       KeyValueStore<TraceIdentity, TraceState> traceStateStore,

diff --git a/...ns-grouper/src/test/java/org/hypertrace/core/rawspansgrouper/TraceEmitPunctuatorTest.java b/...ns-grouper/src/test/java/org/hypertrace/core/rawspansgrouper/TraceEmitPunctuatorTest.java
@@ -11,7 +11,6 @@
 
 import java.nio.ByteBuffer;
 import java.util.List;
-import org.apache.kafka.streams.processor.To;
 import org.apache.kafka.streams.processor.api.ProcessorContext;
 import org.apache.kafka.streams.state.KeyValueStore;
 import org.hypertrace.core.datamodel.Event;
@@ -44,7 +43,6 @@ public void setUp() {
     when(context.keySerde()).thenReturn(avroSerde);
     spanStore = mock(KeyValueStore.class);
     traceStateStore = mock(KeyValueStore.class);
-    To outputTopicProducer = mock(To.class);
     emitCallback =
         new TraceEmitPunctuator(
             mock(ThrottledPunctuatorConfig.class),