HHH-19260 Move supportsXXX methods from the SqlAstTranslator and its base impl to the Dialect class #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrenaat
force-pushed
the
HHH-19260_dialectSupports
branch
4 times, most recently
from
c12eed7 to
6ef525c
Compare
Signed-off-by: Jan Schatteman <[email protected]>
…or to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…ator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…tTranslator (was already in Dialect) Signed-off-by: Jan Schatteman <[email protected]>
Previously, these tests relied on the MySQL dialects returning false for the supportsDistinctFromPredicate() method (came from the base Dialect class), but with the move of this method out of the SqlAstTranslator classes into the actual Dialect classes, it has now become true which made these tests fail Signed-off-by: Jan Schatteman <[email protected]>
…ractSqlAstTranslator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
… Dialect Signed-off-by: Jan Schatteman <[email protected]>
…actSqlAstTranslator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…r to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…AstTranslator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…ator (was already in Dialect) Signed-off-by: Jan Schatteman <[email protected]>
…Translator (not used any more) Signed-off-by: Jan Schatteman <[email protected]>
…anslator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
…AstTranslator to Dialect Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
…ethod from AbstractSqlAstTranslator Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
…ialect Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
…tes() to Dialect Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
…ialect Signed-off-by: Jan Schatteman <[email protected]>
jrenaat
force-pushed
the
HHH-19260_dialectSupports
branch
from
5db6749 to
cb2a8ff
Compare
jrenaat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19260