Skip to content

Commit c12eed7

Browse files
committed
HHH-19260 - HHH-19260 - Move supportsRowValueConstructorSyntax() to Dialect
Signed-off-by: Jan Schatteman <[email protected]>
1 parent 1b89c97 commit c12eed7

File tree

55 files changed

+158
-164
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+158
-164
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CUBRIDDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -527,4 +527,9 @@ public String getFromDualForSelectOnly() {
527527
return " from " + getDual();
528528
}
529529

530+
@Override
531+
public boolean supportsRowValueConstructorSyntax() {
532+
return false;
533+
}
534+
530535
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CUBRIDSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ else if ( expression instanceof Summarization ) {
6363
}
6464
}
6565

66-
@Override
67-
protected boolean supportsRowValueConstructorSyntax() {
68-
return false;
69-
}
70-
7166
@Override
7267
protected boolean supportsRowValueConstructorSyntaxInInList() {
7368
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CacheDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -435,4 +435,9 @@ public void appendDatetimeFormat(SqlAppender appender, String format) {
435435
appender.appendSql( OracleDialect.datetimeFormat( format, false, false ).result() );
436436
}
437437

438+
@Override
439+
public boolean supportsRowValueConstructorSyntax() {
440+
return false;
441+
}
442+
438443
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CacheSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,6 @@ else if ( expression instanceof Summarization ) {
106106
}
107107
}
108108

109-
@Override
110-
protected boolean supportsRowValueConstructorSyntax() {
111-
return false;
112-
}
113-
114109
@Override
115110
protected boolean supportsRowValueConstructorSyntaxInInList() {
116111
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacyDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -1306,4 +1306,10 @@ public String getDual() {
13061306
public String getFromDualForSelectOnly() {
13071307
return " from " + getDual();
13081308
}
1309+
1310+
@Override
1311+
public boolean supportsRowValueConstructorSyntax() {
1312+
return false;
1313+
}
1314+
13091315
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -623,11 +623,6 @@ else if ( expression instanceof Summarization ) {
623623
}
624624
}
625625

626-
@Override
627-
protected boolean supportsRowValueConstructorSyntax() {
628-
return false;
629-
}
630-
631626
@Override
632627
protected boolean supportsRowValueConstructorSyntaxInInList() {
633628
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1077,4 +1077,9 @@ public boolean supportsJoinInMutationStatementSubquery() {
10771077
return false;
10781078
}
10791079

1080+
@Override
1081+
public boolean supportsRowValueConstructorSyntax() {
1082+
return false;
1083+
}
1084+
10801085
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacyDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1083,4 +1083,9 @@ public boolean supportsJoinInMutationStatementSubquery() {
10831083
return false;
10841084
}
10851085

1086+
@Override
1087+
public boolean supportsRowValueConstructorSyntax() {
1088+
return false;
1089+
}
1090+
10861091
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,6 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
283283
}
284284
}
285285

286-
@Override
287-
protected boolean supportsRowValueConstructorSyntax() {
288-
return false;
289-
}
290-
291286
@Override
292287
protected boolean supportsRowValueConstructorSyntaxInInList() {
293288
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,6 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
283283
}
284284
}
285285

286-
@Override
287-
protected boolean supportsRowValueConstructorSyntax() {
288-
return false;
289-
}
290-
291286
@Override
292287
protected boolean supportsRowValueConstructorSyntaxInInList() {
293288
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/FirebirdDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1125,4 +1125,9 @@ public boolean supportsSimpleQueryGrouping() {
11251125
return getVersion().isSameOrAfter( 5 );
11261126
}
11271127

1128+
@Override
1129+
public boolean supportsRowValueConstructorSyntax() {
1130+
return false;
1131+
}
1132+
11281133
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/FirebirdSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -238,11 +238,6 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
238238
}
239239
}
240240

241-
@Override
242-
protected boolean supportsRowValueConstructorSyntax() {
243-
return false;
244-
}
245-
246241
@Override
247242
protected boolean supportsRowValueConstructorSyntaxInInList() {
248243
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -1084,4 +1084,10 @@ public boolean supportsNullPrecedence() {
10841084
return getVersion().isSameOrAfter( 2 );
10851085
}
10861086

1087+
@Override
1088+
public boolean supportsRowValueConstructorSyntax() {
1089+
// Just a guess
1090+
return getVersion().isSameOrAfter( 1, 4, 197 );
1091+
}
1092+
10871093
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java

-6
Original file line numberDiff line numberDiff line change
@@ -346,12 +346,6 @@ public void visitLikePredicate(LikePredicate likePredicate) {
346346
}
347347
}
348348

349-
@Override
350-
protected boolean supportsRowValueConstructorSyntax() {
351-
// Just a guess
352-
return getDialect().getVersion().isSameOrAfter( 1, 4, 197 );
353-
}
354-
355349
@Override
356350
protected boolean supportsRowValueConstructorSyntaxInInList() {
357351
// Just a guess

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacyDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -956,4 +956,9 @@ public boolean supportsArrayConstructor() {
956956
return true;
957957
}
958958

959+
@Override
960+
public boolean supportsRowValueConstructorSyntax() {
961+
return false;
962+
}
963+
959964
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -327,11 +327,6 @@ else if ( expression instanceof Summarization ) {
327327
}
328328
}
329329

330-
@Override
331-
protected boolean supportsRowValueConstructorSyntax() {
332-
return false;
333-
}
334-
335330
@Override
336331
protected boolean supportsRowValueConstructorSyntaxInInList() {
337332
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/InformixDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -910,4 +910,10 @@ public String getDual() {
910910
public String getFromDualForSelectOnly() {
911911
return " from " + getDual() + " dual";
912912
}
913+
914+
@Override
915+
public boolean supportsRowValueConstructorSyntax() {
916+
return false;
917+
}
918+
913919
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/InformixSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,6 @@ else if ( expression instanceof Summarization ) {
136136
}
137137
}
138138

139-
@Override
140-
protected boolean supportsRowValueConstructorSyntax() {
141-
return false;
142-
}
143-
144139
@Override
145140
protected boolean supportsRowValueConstructorSyntaxInInList() {
146141
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/IngresDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -568,4 +568,10 @@ public String getFromDualForSelectOnly() {
568568
//this is only necessary if the query has a where clause
569569
return " from " + getDual() + " dual";
570570
}
571+
572+
@Override
573+
public boolean supportsRowValueConstructorSyntax() {
574+
return false;
575+
}
576+
571577
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/IngresSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,6 @@ else if ( expression instanceof Summarization ) {
120120
}
121121
}
122122

123-
@Override
124-
protected boolean supportsRowValueConstructorSyntax() {
125-
return false;
126-
}
127-
128123
@Override
129124
protected boolean supportsRowValueConstructorSyntaxInInList() {
130125
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MaxDBDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -338,4 +338,10 @@ public String getDual() {
338338
public String getFromDualForSelectOnly() {
339339
return " from " + getDual();
340340
}
341+
342+
@Override
343+
public boolean supportsRowValueConstructorSyntax() {
344+
return false;
345+
}
346+
341347
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MaxDBSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,6 @@ else if ( expression instanceof Summarization ) {
7575
}
7676
}
7777

78-
@Override
79-
protected boolean supportsRowValueConstructorSyntax() {
80-
return false;
81-
}
82-
8378
@Override
8479
protected boolean supportsRowValueConstructorSyntaxInInList() {
8580
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MimerSQLDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -346,4 +346,10 @@ public IdentityColumnSupport getIdentityColumnSupport() {
346346
public String getFromDualForSelectOnly() {
347347
return " from " + getDual();
348348
}
349+
350+
@Override
351+
public boolean supportsRowValueConstructorSyntax() {
352+
return false;
353+
}
354+
349355
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MimerSQLSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,6 @@ else if ( expression instanceof Summarization ) {
6464
}
6565
}
6666

67-
@Override
68-
protected boolean supportsRowValueConstructorSyntax() {
69-
return false;
70-
}
71-
7267
@Override
7368
protected boolean supportsRowValueConstructorSyntaxInInList() {
7469
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacyDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1680,4 +1680,9 @@ public boolean supportsRecursiveSearchClause() {
16801680
return true;
16811681
}
16821682

1683+
@Override
1684+
public boolean supportsRowValueConstructorSyntax() {
1685+
return false;
1686+
}
1687+
16831688
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -670,11 +670,6 @@ else if ( expression instanceof Summarization ) {
670670
}
671671
}
672672

673-
@Override
674-
protected boolean supportsRowValueConstructorSyntax() {
675-
return false;
676-
}
677-
678673
@Override
679674
protected boolean supportsRowValueConstructorSyntaxInInList() {
680675
return getDialect().getVersion().isSameOrAfter( 8, 2 );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/RDMSOS2200Dialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -442,4 +442,10 @@ public String getDual() {
442442
public String getFromDualForSelectOnly() {
443443
return " from " + getDual() + " where key_col=1";
444444
}
445+
446+
@Override
447+
public boolean supportsRowValueConstructorSyntax() {
448+
return false;
449+
}
450+
445451
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/RDMSOS2200SqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,6 @@ else if ( expression instanceof Summarization ) {
108108
}
109109
}
110110

111-
@Override
112-
protected boolean supportsRowValueConstructorSyntax() {
113-
return false;
114-
}
115-
116111
@Override
117112
protected boolean supportsRowValueConstructorSyntaxInInList() {
118113
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLServerLegacyDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1270,4 +1270,9 @@ public boolean supportsSimpleQueryGrouping() {
12701270
return false;
12711271
}
12721272

1273+
@Override
1274+
public boolean supportsRowValueConstructorSyntax() {
1275+
return false;
1276+
}
1277+
12731278
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLServerLegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -555,11 +555,6 @@ public void visitBinaryArithmeticExpression(BinaryArithmeticExpression arithmeti
555555
appendSql( CLOSE_PARENTHESIS );
556556
}
557557

558-
@Override
559-
protected boolean supportsRowValueConstructorSyntax() {
560-
return false;
561-
}
562-
563558
@Override
564559
protected boolean supportsRowValueConstructorSyntaxInInList() {
565560
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SingleStoreDialect.java

+5
Original file line numberDiff line numberDiff line change
@@ -1425,4 +1425,9 @@ public boolean supportsNestedSubqueryCorrelation() {
14251425
return false;
14261426
}
14271427

1428+
@Override
1429+
public boolean supportsRowValueConstructorSyntax() {
1430+
return false;
1431+
}
1432+
14281433
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SingleStoreSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,6 @@ public void visitBinaryArithmeticExpression(BinaryArithmeticExpression arithmeti
7171
}
7272
}
7373

74-
@Override
75-
protected boolean supportsRowValueConstructorSyntax() {
76-
return false;
77-
}
78-
7974
@Override
8075
protected boolean supportsRowValueConstructorSyntaxInInList() {
8176
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseASELegacySqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -561,11 +561,6 @@ protected boolean needsMaxRows() {
561561
return !supportsTopClause();
562562
}
563563

564-
@Override
565-
protected boolean supportsRowValueConstructorSyntax() {
566-
return false;
567-
}
568-
569564
@Override
570565
protected boolean supportsRowValueConstructorSyntaxInInList() {
571566
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseAnywhereSqlAstTranslator.java

-5
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,6 @@ public void visitBinaryArithmeticExpression(BinaryArithmeticExpression arithmeti
222222
appendSql( CLOSE_PARENTHESIS );
223223
}
224224

225-
@Override
226-
protected boolean supportsRowValueConstructorSyntax() {
227-
return false;
228-
}
229-
230225
@Override
231226
protected boolean supportsRowValueConstructorSyntaxInInList() {
232227
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseLegacyDialect.java

+6
Original file line numberDiff line numberDiff line change
@@ -529,4 +529,10 @@ public DmlTargetColumnQualifierSupport getDmlTargetColumnQualifierSupport() {
529529
public boolean supportsFromClauseInUpdate() {
530530
return true;
531531
}
532+
533+
@Override
534+
public boolean supportsRowValueConstructorSyntax() {
535+
return false;
536+
}
537+
532538
}

0 commit comments

Comments
 (0)