RichTooltip/Popover component - hds-register-event modifier [02]
#2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
commented
Mar 21, 2024
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
24da3f7
to
adb62ab
Compare
didoo
changed the base branch from
00-popover-feature-branch
to
01-popover-float-popover-modifier
didoo
force-pushed
the
01-popover-float-popover-modifier
branch
from
6ce1166
to
043b14c
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
adb62ab
to
68dca8a
Compare
didoo
force-pushed
the
01-popover-float-popover-modifier
branch
4 times, most recently
from
3b89e87
to
854ab58
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
68dca8a
to
a93e5f1
Compare
didoo
force-pushed
the
01-popover-float-popover-modifier
branch
from
854ab58
to
2d1a216
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
a93e5f1
to
c074144
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
c074144
to
d582098
Compare
didoo
force-pushed
the
01-popover-float-popover-modifier
branch
from
3ad9f34
to
ea00511
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
894db31
to
78d262a
Compare
didoo
force-pushed
the
01-popover-float-popover-modifier
branch
2 times, most recently
from
5438bb2
to
2d39bd1
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
78d262a
to
a46238d
Compare
didoo
force-pushed
the
02-popover-register-event-modifier
branch
from
a46238d
to
a2db251
Compare
|
Decided to merge this directly to |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR is part of a larger set of PRs: see #2016
It's mainly a porting (with cleanup/refactoring) of #1947
The reason for creating a custom register for DOM event listeners is because the native
{{on}}Ember modifier can't be imported directly in the backing class (to apply it conditionally). See emberjs/ember.js#19869 (comment) / emberjs/ember.js#20629. Thanks @fivetanley for putting me on the right track ;)🛠️ Detailed description
In this PR I have:
hds-register-eventmodifier to assign/remove event listeners to DOM elements🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3211 (Main task)
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.