-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichTooltip/Popover
component - Feature branch [MAIN]
#2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
didoo
force-pushed
the
00-popover-feature-branch
branch
from
April 30, 2024 17:00
be692ef
to
86d2ac0
Compare
This was referenced May 7, 2024
didoo
force-pushed
the
00-popover-feature-branch
branch
from
May 9, 2024 09:52
8418545
to
1956a09
Compare
didoo
force-pushed
the
00-popover-feature-branch
branch
from
May 9, 2024 17:18
70be6e1
to
780e756
Compare
Co-authored-by: Kristin Bradley <[email protected]>
โฆhe min height. Updated the use within helper text.
โฆcessibility.md Co-authored-by: Cristiano Rastelli <[email protected]>
โฆumentation `RichTooltip/Popover` component - `RichTooltip` component documentation [04b]
jorytindall
approved these changes
May 10, 2024
didoo
commented
May 10, 2024
website/public/assets/illustrations/components/components/rich-tooltip.jpg
Outdated
Show resolved
Hide resolved
alex-ju
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a glance over the code again and couldn't spot anything off since the merges.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
This PR will contain all the sub-PRs opened for the
RichTooltip/Popover
component implementation.It's mainly a porting (with cleanup/refactoring) of #1947
๐ ๏ธ Detailed description
This PR is a container for the following sub-PRs:
RichTooltip/Popover
component -hds-anchored-position
modifier [01]ย #2020main
RichTooltip/Popover
component -hds-register-event
modifier [02]ย #2017main
RichTooltip/Popover
component -PopoverPrimitive
component implementation [03]ย #2045RichTooltip/Popover
component -PopoverPrimitive
component documentation [03b]ย #2046RichTooltip/Popover
component -RichTooltip
component implementation [04] ย #2048RichTooltip/Popover
component -RichTooltip
component documentation [04b]ย #2040๐ Preview
๐ External links
Jira tickets:
Figma file: https://www.figma.com/file/noyY6dUMDYjmySpHcMjhkN/branch/ZiYg2uadc2fCNQ5tMzQqi8/HDS-Product---Components?type=design&node-id=55408-54938&mode=design&t=qDUIxW9WBWLLM1HG-0
๐ Component checklist
๐ฌ Please consider using conventional comments when reviewing this PR.