Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15709: Craft Anova GLM Examples #15943

Merged
merged 11 commits into from
Feb 29, 2024
Merged

GH-15709: Craft Anova GLM Examples #15943

merged 11 commits into from
Feb 29, 2024

Conversation

shaunyogeshwaran
Copy link
Contributor

@shaunyogeshwaran shaunyogeshwaran commented Nov 22, 2023

#15709
Crafted new examples to showcase the different parameters.

@shaunyogeshwaran shaunyogeshwaran self-assigned this Nov 22, 2023
@shaunyogeshwaran shaunyogeshwaran changed the title Anova GLM Examples. [DOCS] Craft Anova GLM Examples Nov 22, 2023
@wendycwong
Copy link
Contributor

@shaunyogeshwaran : Thank you for working on this. However, I don't think we need an example for every parameters for ANOVAGLM. In fact, I think the only parameters you want to showcase are those specific to ANOVAGLM. What do you think?

@shaunyogeshwaran
Copy link
Contributor Author

What do you think?

I agree @wendycwong. I think crafting examples for each and every parameter makes the docs look tedious. I will go ahead and make the necessary changes to the other algorithms to only include what's unique to that algorithm.

@shaunyogeshwaran shaunyogeshwaran changed the base branch from master to rel-3.44.0 January 3, 2024 07:40
@shaunyogeshwaran shaunyogeshwaran linked an issue Jan 3, 2024 that may be closed by this pull request
@shaunyogeshwaran shaunyogeshwaran added this to the 3.44.0.4 milestone Jan 3, 2024
@hannah-tillman hannah-tillman changed the title [DOCS] Craft Anova GLM Examples GH-15709: Craft Anova GLM Examples Jan 5, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 12, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 18, 2024
wendycwong
wendycwong previously approved these changes Jan 24, 2024
@shaunyogeshwaran shaunyogeshwaran merged commit 7c207a5 into rel-3.44.0 Feb 29, 2024
66 of 68 checks passed
@shaunyogeshwaran shaunyogeshwaran deleted the sy/15709 branch February 29, 2024 13:38
@mn-mikke mn-mikke removed this from the 3.44.0.4 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anova pydoc updates
4 participants