-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Java 11 #4329
Update to Java 11 #4329
Conversation
243074f
to
039dccb
Compare
// needed by Snyk to accurately report vulnerabilities | ||
// https://docs.snyk.io/scan-application-code/snyk-open-source/snyk-open-source-supported-languages-and-package-managers/snyk-for-scala | ||
addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7bb0a05
to
6fa4e8d
Compare
6fa4e8d
to
64ca948
Compare
@@ -0,0 +1 @@ | |||
java corretto-11.0.24.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an asdf
-formatted .tool-versions
file - I'm trying to nudge people towards standardising on it (see guardian/gha-scala-library-release-workflow#36) and thought I'd add it in here. It does a very similar job to the .java-version file that's already in the project, which I think is a jEnv thing.
Is this PR up for review? I notice some failed deploys to TEST recently: https://riffraff.gutools.co.uk/deployment/history?projectName=media-service%3A%3Agrid%3A%3Aall&page=1. |
Yeah, apologies, I'm pretty sure I've fixed all those issues, but I haven't managed to find a good time to do a deploy to Grid TEST since I did all the fixes (and clearing up a bad deploy on Grid took me a lot of time, as there were a lot of ASGs to fix one by one - is there a better way to do this?!) - just waiting for Tom to finish on Grid TEST. |
I've managed to deploy most of this to TEST, but the two services ( Lines 89 to 96 in d2ec798
I guess I should clone |
The two services (`image-loader` & `cropper`) failed to deploy - although they use Java (and so now need Java 11) they _don't_ use the `editorial-tools-focal-javaX-ARM-WITH-cdk-base` Amigo image - they use `grid-imaging-ARM`: #4329 (comment) ...so I've created a new https://amigo.gutools.co.uk/recipes/grid-imaging-java11-ARM Amigo recipe.
Finally successfully deployed this to TEST, and it looks good: Screen.Recording.2024-09-20.at.17.35.58.mov...so I think this is now ready to review! |
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @rtyley 11 minutes and 17 seconds ago) Please check your changes! |
This has deployed successfully - and the Grid looks good: |
This satisfies one of the updated requirements of Panda v7 - as of guardian/pan-domain-authentication#150 it requires Java 11.
See also:
Testing
Successfully deployed to TEST at 264b2bd:
Screen.Recording.2024-09-20.at.17.35.58.mov
BBC Upgrade
See https://journalism-tools-dev.slack.com/archives/CHYRSQ673/p1728465691605899 - should have highlighted this significant dependency upgrade in the shared Slack.