Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Panda v7 - support key rotation #4330

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Sep 18, 2024

This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150.

This PR sits on top of:

Testing

Successfully deployed to TEST at 8180d55:

Screen.Recording.2024-09-24.at.15.50.49.mov

@rtyley rtyley force-pushed the upgrade-to-panda-v7-support-key-rotation branch from 85c47dd to efccd0c Compare September 18, 2024 16:21
Copy link

github-actions bot commented Sep 18, 2024

@rtyley rtyley force-pushed the upgrade-to-panda-v7-support-key-rotation branch 2 times, most recently from 9867f65 to 61c51b1 Compare September 18, 2024 17:06
@rtyley rtyley force-pushed the update-to-java-11 branch 2 times, most recently from 6fa4e8d to 64ca948 Compare September 18, 2024 17:08
@rtyley rtyley force-pushed the upgrade-to-panda-v7-support-key-rotation branch 2 times, most recently from 846731b to b73d9e3 Compare September 20, 2024 16:45
Base automatically changed from update-to-java-11 to main September 24, 2024 10:09
This upgrades Panda from v5 to v7, allowing us to use key rotation as
introduced with guardian/pan-domain-authentication#150.
@rtyley rtyley force-pushed the upgrade-to-panda-v7-support-key-rotation branch from b73d9e3 to 8180d55 Compare September 24, 2024 11:06
@rtyley rtyley marked this pull request as ready for review September 24, 2024 14:54
@rtyley rtyley requested review from a team as code owners September 24, 2024 14:54
Copy link
Contributor

@Fweddi Fweddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to fully test in TEST, because TEST != CODE for the purpose of domains - but LGTM.

@prout-bot
Copy link

Seen on auth, image-loader, cropper, collections, kahuna (merged by @rtyley 1 hour and 47 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on metadata-editor, leases, media-api (merged by @rtyley 1 hour and 56 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on usage (merged by @rtyley 1 hour, 1 minute and 1 second ago) Please check your changes!

@prout-bot
Copy link

Seen on thrall (merged by @rtyley 1 hour, 1 minute and 13 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants