ab-core uses eslint 9 (take 2) #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/@guardian/browserslist-config/package.json # pnpm-lock.yaml
`source` has no peerdep on `libs`, so we can use the local copy
… into sndrs/use-eslint9-config # Conflicts: # libs/@guardian/ab-react/package.json # libs/@guardian/core-web-vitals/package.json # libs/@guardian/identity-auth/package.json # libs/@guardian/source-development-kitchen/.storybook/main.ts # libs/@guardian/source-development-kitchen/package.json # libs/@guardian/source/.storybook/main.ts # libs/@guardian/source/package.json # pnpm-lock.yaml
|
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
github-actions
bot
added
📦 npm
Co-authored-by: Oliver Abrahams <[email protected]>
oliverabrahams
approved these changes
Sep 6, 2024
…9-config # Conflicts: # libs/@guardian/core-web-vitals/package.json # libs/@guardian/source-development-kitchen/package.json # libs/@guardian/source/package.json # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is 2nd go at #1668, which was accidentally auto-merged into another feature branch...
What are you changing?
@guardian/eslint-configto support ESLint v9 #1658@guardian/eslint-configslightly to re-enable comments lintingWhy?
Anything else?
yeah - noticed doing this that we don't lint anything outside
libs/**, so will add that in a further PR