Use ESLint 9 to lint `libs/**` #1668

sndrs · 2024-08-28T11:44:40Z

What are you changing?

updates the repo to the use the ESLint 9 and the new config added in Update @guardian/eslint-config to support ESLint v9 #1658
updates @guardian/eslint-config slightly to re-enable comments linting
applies some fixes

Why?

staying up to date

Anything else?

yeah - noticed doing this that we don't lint anything outside libs/**, so will add that in a further PR

changeset-bot · 2024-08-28T11:44:44Z

⚠️ No Changeset found

Latest commit: 9ce3663

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-08-28T11:44:54Z

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

sndrs · 2024-08-28T14:13:26Z

seems like there's currently a types conflict when installing @stylistic/eslint-plugin and @eslint/compat: eslint/rewrite#104

sndrs · 2024-09-04T14:40:53Z

seems like there's currently a types conflict when installing @stylistic/eslint-plugin and @eslint/compat: eslint/rewrite#104

fixed by #1689

# Conflicts: # libs/@guardian/browserslist-config/package.json # pnpm-lock.yaml

oliverabrahams · 2024-09-06T10:44:20Z

libs/@guardian/ab-core/eslint.config.js

+	...guardian.configs.jest,
+	{
+		ignores: [
+			'node_modules',


This is ignored automatically by eslint, can see the argument for writing it anyway

oliverabrahams

Removed unnecessary ignore node_modules

oliverabrahams · 2024-09-06T10:49:29Z

libs/@guardian/ab-core/eslint.config.js

+	...guardian.configs.jest,
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

oliverabrahams · 2024-09-06T10:49:45Z

libs/@guardian/ab-react/eslint.config.js

+	...guardian.configs.react,
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

oliverabrahams · 2024-09-06T10:49:59Z

libs/@guardian/browserslist-config/eslint.config.mjs

+export default [
+	...guardian.configs.recommended,
+	{
+		ignores: ['node_modules', '.wireit'],


Suggested change

ignores: ['node_modules', '.wireit'],

ignores: ['.wireit'],

libs/@guardian/core-web-vitals/eslint.config.js

oliverabrahams · 2024-09-06T10:50:22Z

libs/@guardian/identity-auth-frontend/eslint.config.js

+	...guardian.configs.jest,
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

oliverabrahams · 2024-09-06T10:50:40Z

libs/@guardian/libs/eslint.config.js

+	...guardian.configs.jest,
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

oliverabrahams · 2024-09-06T10:50:54Z

libs/@guardian/newsletter-types/eslint.config.js

+export default [
+	...guardian.configs.recommended,
+	{
+		ignores: ['node_modules', 'dist', '.wireit'],


Suggested change

ignores: ['node_modules', 'dist', '.wireit'],

ignores: ['dist', '.wireit'],

oliverabrahams · 2024-09-06T10:51:05Z

libs/@guardian/prettier/eslint.config.mjs

+export default [
+	...guardian.configs.recommended,
+	{
+		ignores: ['node_modules', '.wireit'],


Suggested change

ignores: ['node_modules', '.wireit'],

ignores: ['.wireit'],

oliverabrahams · 2024-09-06T10:51:14Z

libs/@guardian/source-development-kitchen/eslint.config.js

+export default [
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

oliverabrahams · 2024-09-06T10:51:26Z

libs/@guardian/source/eslint.config.js

+export default [
+	{
+		ignores: [
+			'node_modules',


Suggested change

'node_modules',

… into sndrs/use-eslint9-config # Conflicts: # libs/@guardian/ab-react/package.json # libs/@guardian/core-web-vitals/package.json # libs/@guardian/identity-auth/package.json # libs/@guardian/source-development-kitchen/.storybook/main.ts # libs/@guardian/source-development-kitchen/package.json # libs/@guardian/source/.storybook/main.ts # libs/@guardian/source/package.json # pnpm-lock.yaml

sndrs · 2024-09-06T12:19:46Z

replace (accidentally) by #1696

sndrs requested review from a team as code owners August 28, 2024 11:44

sndrs requested a review from a team August 28, 2024 11:44

sndrs requested a review from a team as a code owner August 28, 2024 11:44

sndrs self-assigned this Aug 28, 2024

sndrs added the run_chromatic Runs chromatic when label is applied label Aug 28, 2024

github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs @guardian/browserslist-config @guardian/prettier @guardian/ab-core @guardian/ab-react labels Aug 28, 2024

sndrs linked an issue Aug 28, 2024 that may be closed by this pull request

Consume ESLint 9 configs in CSNX #1664

Open

sndrs mentioned this pull request Aug 28, 2024

Move tools/scripts/** to scripts #1669

Merged

This was referenced Aug 28, 2024

Make all storybook configs TS #1671

Merged

Temporarily disable @stylistic plugin in eslint-config #1688

Closed

Use @eslint-community/eslint-plugin-eslint-comments #1689

Merged

sndrs force-pushed the sndrs/use-eslint9-config branch from 4989920 to d3d18a0 Compare September 4, 2024 14:39

github-actions bot added the @guardian/eslint-config label Sep 4, 2024

sndrs changed the base branch from main to sndrs/eslint9/comments September 4, 2024 14:40

Base automatically changed from sndrs/eslint9/comments to main September 4, 2024 14:40

sndrs force-pushed the sndrs/use-eslint9-config branch from d3d18a0 to 543565e Compare September 4, 2024 14:42

github-actions bot removed the @guardian/eslint-config label Sep 4, 2024

sndrs enabled auto-merge (squash) September 4, 2024 14:43

sndrs force-pushed the sndrs/use-eslint9-config branch from 44c5ae2 to c0c8f13 Compare September 5, 2024 13:21

sndrs added 17 commits September 6, 2024 11:14

ab-core uses eslint 9

fdacc05

ab-react uses eslint 9

b926e51

browserslist-config uses eslint 9

831009b

# Conflicts: # libs/@guardian/browserslist-config/package.json # pnpm-lock.yaml

core-web-vitals uses eslint 9

3d8ca95

identity-auth uses eslint 9

13249d4

libs uses on eslint 9

cb3f9ce

identity-auth-frontend uses eslint 9

8160b4f

prettier uses eslint 9

60cb785

newsletter-types uses eslint 9

500ba8d

source-development-kitchen uses eslint 9

7fa4831

source uses eslint 9

a094e39

update lockfile

edc691a

remove old eslint root config

57328a3

remove eslint deps from root

645bdfb

Rejig @eslint-community/eslint-plugin-eslint-comments config

a6d04e1

lint fixes

760e391

remove unnecessary spec

d83f07e

sndrs force-pushed the sndrs/use-eslint9-config branch from c0c8f13 to d83f07e Compare September 6, 2024 10:14

sndrs disabled auto-merge September 6, 2024 10:14

sndrs enabled auto-merge September 6, 2024 10:14

oliverabrahams reviewed Sep 6, 2024

View reviewed changes

sndrs changed the base branch from main to sndrs/restore-libs-version September 6, 2024 12:06

sndrs merged commit 751a6e1 into sndrs/restore-libs-version Sep 6, 2024
4 checks passed

sndrs deleted the sndrs/use-eslint9-config branch September 6, 2024 12:11

sndrs mentioned this pull request Sep 6, 2024

Revert "Use ESLint 9 to lint libs/**" #1695

Merged

sndrs restored the sndrs/use-eslint9-config branch September 6, 2024 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ESLint 9 to lint `libs/**` #1668

Use ESLint 9 to lint `libs/**` #1668

sndrs commented Aug 28, 2024 •

edited

Loading

changeset-bot bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024

sndrs commented Aug 28, 2024

sndrs commented Sep 4, 2024

oliverabrahams Sep 6, 2024

oliverabrahams left a comment

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

oliverabrahams Sep 6, 2024

sndrs commented Sep 6, 2024

	ignores: ['node_modules', 'dist', '.wireit'],
	ignores: ['dist', '.wireit'],

Use ESLint 9 to lint libs/** #1668

Use ESLint 9 to lint libs/** #1668

Conversation

sndrs commented Aug 28, 2024 • edited Loading

What are you changing?

Why?

Anything else?

changeset-bot bot commented Aug 28, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Aug 28, 2024

sndrs commented Aug 28, 2024

sndrs commented Sep 4, 2024

Choose a reason for hiding this comment

oliverabrahams left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sndrs commented Sep 6, 2024

Use ESLint 9 to lint `libs/**` #1668

Use ESLint 9 to lint `libs/**` #1668

sndrs commented Aug 28, 2024 •

edited

Loading

changeset-bot bot commented Aug 28, 2024 •

edited

Loading