Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @eslint-community/eslint-plugin-eslint-comments #1689

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Use @eslint-community/eslint-plugin-eslint-comments #1689

merged 1 commit into from
Sep 4, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Sep 4, 2024

What are you changing?

  • Replaces eslint-plugin-eslint-comments with @eslint-community/eslint-plugin-eslint-comments
  • Bumps other dependencies

Why?

@eslint-community/eslint-plugin-eslint-comments supports eslint 9 flat configs, and removes a types clash that blocks #1668

@sndrs sndrs requested a review from a team as a code owner September 4, 2024 14:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 815dc3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/eslint-config labels Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs mentioned this pull request Sep 4, 2024
Closed
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Sep 4, 2024
@sndrs sndrs enabled auto-merge (squash) September 4, 2024 14:37
joecowton1
joecowton1 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@joecowton1 joecowton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done

@sndrs sndrs merged commit f77f690 into main Sep 4, 2024
21 checks passed
@sndrs sndrs deleted the sndrs/eslint9/comments branch September 4, 2024 14:40
sndrs added a commit that referenced this pull request Sep 6, 2024
@sndrs
Use @eslint-community/eslint-plugin-eslint-comments (#1689)
e8c4438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecowton1 joecowton1 joecowton1 approved these changes

Assignees
No one assigned
Labels
@guardian/eslint-config 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @joecowton1