Add simple server timeout #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ ClientStream newStream(MethodDescriptor<?, ?> method, | |||
| ClientStreamListener listener); | |||
|
|
|||
| /** | |||
| * Starts transport. Implementations must not call {@code listener} until after {@code start()} | |||
| * Starts transport. Implementations must not call {@code listener} until after {@link #start} | |||
There was a problem hiding this comment.
Using @code is fine here, since the link doesn't add much value.
There was a problem hiding this comment.
it does add a little value, in case the method name ever changes. Also, cross references look at the @link annotation (such as in CS and IDEs).
There was a problem hiding this comment.
Cross-references doesn't make sense here though, since it is referring to itself.
I do think it was a conscious decision to use code instead of link. The fact it is code also reduces the noise of the JavaDoc. But whatever.
|
@carl-mastrangelo LGTM. Two small comments. We'll need to reassign #58 after this goes in for implementing |
Reintroduce throws Add timeoutExecutor shutdown Use a default future Move timeout cancellation Cancel the timeout in error cases
carl-mastrangelo
force-pushed
the
scratch
branch
from
9f3156a to
0003e44
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ejona86: This depends slightly on #576 and addresses #58