Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for 2D per-instance uniforms in Shading language #10749

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 6, 2025

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders cherrypick:4.4 labels Mar 6, 2025
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supersedes #10737 if merged.

This section also mentions GeometryInstance3D specifically a few places. Those should likely be amended to also mention CanvasItem too.

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied tetrapod's suggestion

EDIT: for reference, PR that added this feature: godotengine/godot#99230

@skyace65 skyace65 merged commit 93963ab into godotengine:master Apr 5, 2025
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Apr 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.4 enhancement topic:shaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants