Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[signal]: validate that there is no function body #1032

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Feb 1, 2025

It was accidentally possible to provide a function body #[signal], which caused some confusion with a user about that code never being executed.

@Bromeon Bromeon added bug c: register Register classes, functions and other symbols to GDScript labels Feb 1, 2025
@Bromeon Bromeon added this pull request to the merge queue Feb 1, 2025
Merged via the queue into master with commit 2f4320f Feb 1, 2025
15 checks passed
@Bromeon Bromeon deleted the bugfix/signal-nobody branch February 1, 2025 16:10
@Bromeon Bromeon added the breaking-change Requires SemVer bump label Feb 1, 2025
@Bromeon
Copy link
Member Author

Bromeon commented Feb 1, 2025

Marked breaking, but all usages of this pattern have been wrong already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Requires SemVer bump bug c: register Register classes, functions and other symbols to GDScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant