Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt #2546

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jul 8, 2024

Description

Removes the usage of the deprecated ast.Object type and replaces it with ast.Ident. Since ast.Ident contains name and location information, I think it would provide the information that needed in most cases.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.73%. Comparing base (11a5027) to head (991803f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
- Coverage   60.92%   60.73%   -0.19%     
==========================================
  Files         564      564              
  Lines       75273    77633    +2360     
==========================================
+ Hits        45857    47153    +1296     
- Misses      26048    26984     +936     
- Partials     3368     3496     +128     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.17% <ø> (ø)
gnovm 65.77% <100.00%> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 61.94% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon changed the title Chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt Jul 8, 2024
@moul moul requested a review from gfanton July 8, 2024 11:42
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the changes, it seems like a simple type swap that doesn't modify anything persistent 👍

gnovm/pkg/gnofmt/processor.go Outdated Show resolved Hide resolved
@thehowl thehowl merged commit 09b6241 into gnolang:master Oct 2, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants