-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In gnofmt
#2546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2546 +/- ##
==========================================
- Coverage 60.92% 60.73% -0.19%
==========================================
Files 564 564
Lines 75273 77633 +2360
==========================================
+ Hits 45857 47153 +1296
- Misses 26048 26984 +936
- Partials 3368 3496 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gnofmt
gnofmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changes, it seems like a simple type swap that doesn't modify anything persistent 👍
Description
Removes the usage of the deprecated
ast.Object
type and replaces it withast.Ident
. Sinceast.Ident
contains name and location information, I think it would provide the information that needed in most cases.