chore(gnovm/gnofmt): Replace usage of ast.Object with ast.Ident In `g…

…nofmt` (#2546)

# Description

Removes the usage of the deprecated `ast.Object` type and replaces it
with `ast.Ident`. Since `ast.Ident` contains name and location
information, I think it would provide the information that needed in
most cases.

gnovm/pkg/gnofmt/processor.go

@@ -16,10 +16,15 @@ import (
 
 const tabWidth = 8
 
+type (
+	declMap map[*ast.Ident]ast.Decl
+	fileMap map[string]*ast.File
+)
+
 type parsedPackage struct {
 	error error
-	files map[string]*ast.File
-	decls map[*ast.Object]ast.Decl
+	files fileMap
+	decls declMap
 }
 
 type Processor struct {
@@ -52,7 +57,7 @@ func (p *Processor) FormatImportFromSource(filename string, src any) ([]byte, er
 	}
 
 	// Collect top level declarations within the source
-	pkgDecls := make(map[*ast.Object]ast.Decl)
+	pkgDecls := make(declMap)
 	collectTopDeclaration(nodefile, pkgDecls)
 
 	// Process and format the parsed node.
@@ -129,7 +134,7 @@ func (p *Processor) parseFile(path string, src any) (file *ast.File, err error)
 }
 
 // Helper function to process and format a parsed AST node.
-func (p *Processor) processAndFormat(file *ast.File, filename string, topDecls map[*ast.Object]ast.Decl) ([]byte, error) {
+func (p *Processor) processAndFormat(file *ast.File, filename string, topDecls declMap) ([]byte, error) {
 	// Collect unresolved
 	unresolved := collectUnresolved(file, topDecls)
 
@@ -167,8 +172,8 @@ func (p *Processor) processPackageFiles(path string, pkg Package) *parsedPackage
 	}
 
 	pkgc = &parsedPackage{
-		decls: make(map[*ast.Object]ast.Decl),
-		files: map[string]*ast.File{},
+		decls: make(declMap),
+		files: make(fileMap),
 	}
 	pkgc.error = ReadWalkPackage(pkg, func(filename string, r io.Reader, err error) error {
 		if err != nil {
@@ -190,31 +195,31 @@ func (p *Processor) processPackageFiles(path string, pkg Package) *parsedPackage
 }
 
 // collectTopDeclaration collects top-level declarations from a single file.
-func collectTopDeclaration(file *ast.File, topDecls map[*ast.Object]ast.Decl) {
+func collectTopDeclaration(file *ast.File, topDecls declMap) {
 	for _, decl := range file.Decls {
 		switch d := decl.(type) {
 		case *ast.GenDecl:
 			for _, spec := range d.Specs {
 				switch s := spec.(type) {
 				case *ast.TypeSpec:
-					topDecls[s.Name.Obj] = d
+					topDecls[s.Name] = d
 				case *ast.ValueSpec:
 					for _, name := range s.Names {
-						topDecls[name.Obj] = d
+						topDecls[name] = d
 					}
 				}
 			}
 		case *ast.FuncDecl:
 			// Check for top-level function
 			if d.Recv == nil && d.Name != nil && d.Name.Obj != nil {
-				topDecls[d.Name.Obj] = d
+				topDecls[d.Name] = d
 			}
 		}
 	}
 }
 
 // collectUnresolved collects unresolved identifiers and declarations.
-func collectUnresolved(file *ast.File, topDecls map[*ast.Object]ast.Decl) map[string]map[string]bool {
+func collectUnresolved(file *ast.File, topDecls declMap) map[string]map[string]bool {
 	unresolved := map[string]map[string]bool{}
 	unresolvedList := []*ast.Ident{}
 	for _, u := range file.Unresolved {
@@ -233,7 +238,7 @@ func collectUnresolved(file *ast.File, topDecls map[*ast.Object]ast.Decl) map[st
 	ast.Inspect(file, func(n ast.Node) bool {
 		switch e := n.(type) {
 		case *ast.Ident:
-			if d := topDecls[e.Obj]; d != nil {
+			if _, ok := topDecls[e]; ok {
 				delete(unresolved, e.Name)
 			}
 		case *ast.SelectorExpr:
@@ -260,7 +265,7 @@ func collectUnresolved(file *ast.File, topDecls map[*ast.Object]ast.Decl) map[st
 }
 
 // cleanupPreviousImports removes resolved imports from the unresolved list.
-func (p *Processor) cleanupPreviousImports(node *ast.File, knownDecls map[*ast.Object]ast.Decl, unresolved map[string]map[string]bool) {
+func (p *Processor) cleanupPreviousImports(node *ast.File, knownDecls declMap, unresolved map[string]map[string]bool) {
 	imports := astutil.Imports(p.fset, node)
 	for _, imps := range imports {
 		for _, imp := range imps {
@@ -290,8 +295,8 @@ func (p *Processor) cleanupPreviousImports(node *ast.File, knownDecls map[*ast.O
 	}
 
 	// Mark knownDecls as resolved
-	for obj := range knownDecls {
-		delete(unresolved, obj.Name)
+	for ident := range knownDecls {
+		delete(unresolved, ident.Name)
 	}
 }